Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 1143003008: Simplify UserAgentShadowRoot check for /deep/ selectors. (Closed)

Created:
5 years, 6 months ago by esprehn
Modified:
5 years, 6 months ago
Reviewers:
Timothy Loh, hayato
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Simplify UserAgentShadowRoot check for /deep/ selectors. User agent shadow roots cannot nest author shadow roots, so there's no reason to check the type as we ascend every ancestor. Instead we can just check the starting element in the checker. R=timloh@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196286

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -14 lines) Patch
M Source/core/css/SelectorChecker.cpp View 3 chunks +7 lines, -14 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
esprehn
5 years, 6 months ago (2015-06-02 03:51:39 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143003008/1
5 years, 6 months ago (2015-06-02 03:54:00 UTC) #4
hayato
LGTM. Note that I think we need to bring this change back when we are ...
5 years, 6 months ago (2015-06-02 04:20:54 UTC) #5
esprehn
On 2015/06/02 at 04:20:54, hayato wrote: > LGTM. > > Note that I think we ...
5 years, 6 months ago (2015-06-02 04:30:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143003008/1
5 years, 6 months ago (2015-06-02 04:30:41 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-02 05:21:18 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196286

Powered by Google App Engine
This is Rietveld 408576698