Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(586)

Issue 1143003003: X87: [crankshaft] Record inlined shared function infos instead of closures. (Closed)

Created:
5 years, 6 months ago by chunyang.dai
Modified:
5 years, 6 months ago
Reviewers:
Weiliang
CC:
v8-dev, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: [crankshaft] Record inlined shared function infos instead of closures. port 388e791df91c299507d62f91bc4f618a4dc80276 (r28672). original commit message: The list of inlined functions is used in exactly two places - for live edit and to prevent code flushing for inlined functions - and those are fine with SharedFunctionInfo and don't require a closure. This is one additional step towards inlining based on SharedFunctionInfo instead of JSFunction. BUG= Committed: https://crrev.com/aa31176ab19baeea1c8decafc98f333696cc13a2 Cr-Commit-Position: refs/heads/master@{#28719}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -11 lines) Patch
M src/x87/lithium-codegen-x87.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 6 months ago (2015-06-01 06:15:38 UTC) #2
Weiliang
lgtm
5 years, 6 months ago (2015-06-01 08:24:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1143003003/1
5 years, 6 months ago (2015-06-01 08:24:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-01 09:11:33 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-01 09:11:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/aa31176ab19baeea1c8decafc98f333696cc13a2
Cr-Commit-Position: refs/heads/master@{#28719}

Powered by Google App Engine
This is Rietveld 408576698