Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5164)

Unified Diff: chrome/browser/extensions/api/permissions/permissions_apitest.cc

Issue 1142993002: Don't send unnecessary ExtensionMsg_Loaded IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: commnets Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_startup_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/permissions/permissions_apitest.cc
diff --git a/chrome/browser/extensions/api/permissions/permissions_apitest.cc b/chrome/browser/extensions/api/permissions/permissions_apitest.cc
index 9b980729157723dd0fdc7d4e27d5f3daababb258..0cd5a4e888569d4fe6bf5b5589d6bfd07a1aa1ba 100644
--- a/chrome/browser/extensions/api/permissions/permissions_apitest.cc
+++ b/chrome/browser/extensions/api/permissions/permissions_apitest.cc
@@ -195,4 +195,13 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, HostSubsets) {
EXPECT_TRUE(RunExtensionTest("permissions/host_subsets")) << message_;
}
+// Tests that requesting an optional permission from a background page, with
+// another window open, grants the permission and updates the bindings
+// (chrome.whatever, in this case chrome.alarms). Regression test for
+// crbug.com/435141, see details there for trickiness.
+IN_PROC_BROWSER_TEST_F(ExtensionApiTest, OptionalPermissionsUpdatesBindings) {
+ ASSERT_TRUE(RunExtensionTest("permissions/optional_updates_bindings"))
+ << message_;
+}
+
} // namespace extensions
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_startup_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698