chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc - Issue 1142993002: Don't send unnecessary ExtensionMsg_Loaded IPCs.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/renderer/extensions/renderer_permissions_policy_delegate_unittest.cc

Issue 1142993002: Don't send unnecessary ExtensionMsg_Loaded IPCs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: commnets Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « chrome/browser/extensions/extension_startup_browsertest.cc ('k') | chrome/test/data/extensions/api_test/permissions/optional_updates_bindings/background.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #include "base/command_line.h"	5 #include "base/command_line.h"

6 #include "chrome/common/extensions/extension_constants.h"	6 #include "chrome/common/extensions/extension_constants.h"

7 #include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"	7 #include "chrome/renderer/extensions/chrome_extensions_dispatcher_delegate.h"

8 #include "chrome/renderer/extensions/renderer_permissions_policy_delegate.h"	8 #include "chrome/renderer/extensions/renderer_permissions_policy_delegate.h"

9 #include "content/public/test/mock_render_process_host.h"	9 #include "content/public/test/mock_render_process_host.h"

10 #include "content/public/test/mock_render_thread.h"	10 #include "content/public/test/mock_render_thread.h"

(...skipping 56 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
67 std::string error;	67 std::string error;

68	68

69 EXPECT_TRUE(extension->permissions_data()->CanAccessPage(	69 EXPECT_TRUE(extension->permissions_data()->CanAccessPage(

70 extension.get(), kAnyUrl, kAnyUrl, -1, -1, &error))	70 extension.get(), kAnyUrl, kAnyUrl, -1, -1, &error))

71 << error;	71 << error;

72	72

73 // Pretend we are in the webstore process. We should not be able to execute	73 // Pretend we are in the webstore process. We should not be able to execute

74 // script.	74 // script.

75 scoped_refptr<const Extension> webstore_extension(	75 scoped_refptr<const Extension> webstore_extension(

76 CreateTestExtension(extensions::kWebStoreAppId));	76 CreateTestExtension(extensions::kWebStoreAppId));

77 extension_dispatcher_->OnLoadedInternal(webstore_extension);	77 extension_dispatcher_->LoadExtensionForTest(webstore_extension.get());

78 extension_dispatcher_->OnActivateExtension(extensions::kWebStoreAppId);	78 extension_dispatcher_->OnActivateExtension(extensions::kWebStoreAppId);

79 EXPECT_FALSE(extension->permissions_data()->CanAccessPage(	79 EXPECT_FALSE(extension->permissions_data()->CanAccessPage(

80 extension.get(), kAnyUrl, kAnyUrl, -1, -1, &error))	80 extension.get(), kAnyUrl, kAnyUrl, -1, -1, &error))

81 << error;	81 << error;

82 }	82 }

83	83

84 } // namespace extensions	84 } // namespace extensions

OLD	NEW