Don't send unnecessary ExtensionMsg_Loaded IPCs.

extensions/renderer/dispatcher.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef EXTENSIONS_RENDERER_DISPATCHER_H_
 #define EXTENSIONS_RENDERER_DISPATCHER_H_
 
 #include <map>
 #include <set>
 #include <string>
@@ skipping 119 matching lines @@
   static std::vector<std::pair<std::string, int> > GetJsResources();
   static void RegisterNativeHandlers(ModuleSystem* module_system,
                                      ScriptContext* context,
                                      Dispatcher* dispatcher,
                                      RequestSender* request_sender,
                                      V8SchemaRegistry* v8_schema_registry);
 
   bool WasWebRequestUsedBySomeExtensions() const { return webrequest_used_; }
 
  private:
+  // The RendererPermissionsPolicyDelegateTest.CannotScriptWebstore test needs
+  // to call InsertExtensionForTest and the OnActivateExtension IPCs.

[Devlin, 2015/06/03 20:53:37]

There is no InsertExtensionForTest ;)

[not at google - send to devlin, 2015/06/03 21:53:03]

LoadExtensionForTest, oops.

   friend class ::ChromeRenderViewTest;
   FRIEND_TEST_ALL_PREFIXES(RendererPermissionsPolicyDelegateTest,
                            CannotScriptWebstore);
 
+  // Inserts an Extension into |extensions_|. Normally the only way to do this
+  // would be through the ExtensionMsg_Loaded IPC (OnLoaded) but this can't be
+  // triggered for tests, because in the process of serializing then
+  // deserializing the IPC, Extension IDs manually set for testing are lost.
+  void LoadExtensionForTest(const Extension* extension);
+
   // RenderProcessObserver implementation:
   bool OnControlMessageReceived(const IPC::Message& message) override;
   void WebKitInitialized() override;
   void IdleNotification() override;
   void OnRenderProcessShutdown() override;
 
   void OnActivateExtension(const std::string& extension_id);
   void OnCancelSuspend(const std::string& extension_id);
   void OnDeliverMessage(int target_port_id, const Message& message);
   void OnDispatchOnConnect(int target_port_id,
                            const std::string& channel_name,
                            const ExtensionMsg_TabConnectionInfo& source,
                            const ExtensionMsg_ExternalConnectionInfo& info,
                            const std::string& tls_channel_id);
   void OnDispatchOnDisconnect(int port_id, const std::string& error_message);
   void OnLoaded(
       const std::vector<ExtensionMsg_Loaded_Params>& loaded_extensions);
-  void OnLoadedInternal(scoped_refptr<const Extension> extension);
   void OnMessageInvoke(const std::string& extension_id,
                        const std::string& module_name,
                        const std::string& function_name,
                        const base::ListValue& args,
                        bool user_gesture);
   void OnSetChannel(int channel);
   void OnSetFunctionNames(const std::vector<std::string>& names);
   void OnSetScriptingWhitelist(
       const ExtensionsClient::ScriptingWhitelist& extension_ids);
   void OnSetSystemFont(const std::string& font_family,
@@ skipping 133 matching lines @@
 
   // Status of webrequest usage.
   bool webrequest_used_;
 
   DISALLOW_COPY_AND_ASSIGN(Dispatcher);
 };
 
 }  // namespace extensions
 
 #endif  // EXTENSIONS_RENDERER_DISPATCHER_H_