Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(450)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1142893007: Suppress unnamed library analyzer spam in shelldb (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
abarth-chromium
CC:
abarth-chromium, gregsimon, mojo-reviews_chromium.org, ojan, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Suppress unnamed library analyzer spam in shelldb Revert "Add library names to many sky libraries" This reverts commit 1337e0a803a54ee92d6dce7f8c4a6335f7cbb9fa. BUG= R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/07e4e2e72a3a1c28ff6b9aa378ace79ff5e66b88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -75 lines) Patch
M sky/examples/stocks/lib/stock_arrow.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/examples/stocks/lib/stock_data.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/examples/stocks/lib/stock_list.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/animation/animated_value.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/animation/curves.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/animation/generators.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/animation/mechanics.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/animation/scroll_behavior.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/action_bar.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/animated_component.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/button.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/button_base.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/checkbox.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/drawer.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/drawer_header.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/fixed_height_scrollable.dart View 2 chunks +1 line, -3 lines 0 comments Download
M sky/sdk/lib/framework/components/floating_action_button.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/icon.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/icon_button.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/ink_splash.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/ink_well.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/input.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/material.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/menu_divider.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/menu_item.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/modal_overlay.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/popup_menu.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/popup_menu_item.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/radio.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/scaffold.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/components/scrollable.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/debug/tracing.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/editing/editable_string.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/editing/editable_text.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/editing/keyboard.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/theme/colors.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/sdk/lib/framework/theme/typography.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/tools/shelldb View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Cutch
5 years, 7 months ago (2015-05-19 17:25:03 UTC) #2
abarth-chromium
lgtm
5 years, 7 months ago (2015-05-19 17:25:31 UTC) #3
Cutch
5 years, 7 months ago (2015-05-19 17:25:49 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
07e4e2e72a3a1c28ff6b9aa378ace79ff5e66b88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698