Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Issue 1142893005: Add minSdkVersion=21 to ABI split manifests (Closed)

Created:
5 years, 7 months ago by agrieve
Modified:
5 years, 7 months ago
Reviewers:
jbudorick
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@split-abi
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add minSdkVersion=21 to ABI split manifests Appears to be required for split-select to work BUG=484797 Committed: https://crrev.com/15390e42957d99e29177576d91d77cb3053a52aa Cr-Commit-Position: refs/heads/master@{#330615}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/android/gyp/generate_split_manifest.py View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
agrieve
5 years, 7 months ago (2015-05-19 14:42:24 UTC) #2
jbudorick
lgtm
5 years, 7 months ago (2015-05-19 15:43:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142893005/1
5 years, 7 months ago (2015-05-19 20:27:37 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 21:40:45 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 21:41:45 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15390e42957d99e29177576d91d77cb3053a52aa
Cr-Commit-Position: refs/heads/master@{#330615}

Powered by Google App Engine
This is Rietveld 408576698