ui/webui/resources/css/roboto.css - Issue 1142893002: Add Roboto-Medium webfont and factor out common Roboto WebUI CSS file.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/webui/resources/css/roboto.css

Issue 1142893002: Add Roboto-Medium webfont and factor out common Roboto WebUI CSS file. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 /* Copyright 2015 The Chromium Authors. All rights reserved.

	2 * Use of this source code is governed by a BSD-style license that can be

	3 * found in the LICENSE file. */

	4 @font-face {
	michaelpg 2015/05/19 03:21:57 nit: newline above declaration block nit: newline above declaration block tsergeant 2015/05/19 03:35:59 Done. Show quoted text On 2015/05/19 03:21:57, michaelpg wrote: > nit: newline above declaration block Done.
	5 font-family: 'Roboto';

	6 font-style: normal;

	7 font-weight: 400;

	8 src: local('Roboto'), local('Roboto-Regular'),

	9 url(chrome://resources/roboto/roboto-regular-latin.woff2) format('woff2');

	10 unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC,
	michaelpg 2015/05/19 03:21:57 this is a very different set than the other CSS fi this is a very different set than the other CSS files had. Can you explain where these code points came from/why they're right? tsergeant 2015/05/19 03:35:59 The unicode-range from the old files was actually Show quoted text On 2015/05/19 03:21:57, michaelpg wrote: > this is a very different set than the other CSS files had. Can you explain where > these code points came from/why they're right? The unicode-range from the old files was actually incorrect. These ranges both came from the output of fonts.googleapis.com. Inspecting the old range shows that it is Cyrillic (U+460, for example, maps to Ѡ), while U+0000-00FF (which includes all of ASCII) from the new range is a good hint that it corresponds to Latin. michaelpg 2015/05/19 07:21:27 Great, thanks for explaining. Glad to have this al Show quoted text On 2015/05/19 03:35:59, tsergeant wrote: > On 2015/05/19 03:21:57, michaelpg wrote: > > this is a very different set than the other CSS files had. Can you explain > where > > these code points came from/why they're right? > > The unicode-range from the old files was actually incorrect. These ranges both > came from the output of http://fonts.googleapis.com. Inspecting the old range shows > that it is Cyrillic (U+460, for example, maps to Ѡ), while U+0000-00FF (which > includes all of ASCII) from the new range is a good hint that it corresponds to > Latin. Great, thanks for explaining. Glad to have this all in one place now.
	11 U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000;

	12 }

	13 @font-face {
	michaelpg 2015/05/19 03:21:57 same nit same nit tsergeant 2015/05/19 03:35:59 Done. Show quoted text On 2015/05/19 03:21:57, michaelpg wrote: > same nit Done.
	14 font-family: 'Roboto';

	15 font-style: normal;

	16 font-weight: 500;

	17 src: local('Roboto Medium'), local('Roboto-Medium'),

	18 url(chrome://resources/roboto/roboto-medium-latin.woff2) format('woff2');

	19 unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC,

	20 U+2000-206F, U+2074, U+20AC, U+2212, U+2215, U+E0FF, U+EFFD, U+F000;

	21 }

OLD	NEW

« no previous file with comments | « components/proximity_auth/webui/resources/proximity_auth.html ('k') | ui/webui/resources/roboto/roboto.woff » ('j') | no next file with comments »