Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 1142893002: Add Roboto-Medium webfont and factor out common Roboto WebUI CSS file. (Closed)

Created:
5 years, 7 months ago by tsergeant
Modified:
5 years, 7 months ago
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, khorimoto+watch-md-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, jhawkins+watch-md-settings_chromium.org, orenb+watch-md-settings_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch-md-settings_chromium.org, jlklein+watch-md-settings_chromium.org, Tim Song, pedro (no code reviews)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Roboto-Medium webfont and factor out common Roboto WebUI CSS file. The common file prevents duplication of the same @font-face definitions, and allows additional font weights and character sets added by one project to be automatically available for all other Roboto users. This CL also updates the Roboto font files from Google Fonts and removes the .woff file, since Chrome has complete support for woff2. BUG=439114 TEST=Locally tested chrome://md-settings, chrome://proximity-auth and a PDF file on desktop, and chrome://contextual-search-promo/promo.html on Android. Committed: https://crrev.com/52eb6dd02c535873dda638dcd5e08e1fc7af5538 Cr-Commit-Position: refs/heads/master@{#330689}

Patch Set 1 #

Patch Set 2 : #

Total comments: 7

Patch Set 3 : Fix CSS nits #

Patch Set 4 : Rearrange properties in promo.css to abate presubmit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -39 lines) Patch
M chrome/browser/resources/contextual_search/promo.css View 1 2 3 4 chunks +3 lines, -12 lines 0 comments Download
M chrome/browser/resources/contextual_search/promo.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_settings/md_settings.css View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/md_settings/md_settings.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/pdf/index-material.css View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/pdf/index-material.html View 1 chunk +1 line, -0 lines 0 comments Download
M components/proximity_auth/webui/resources/proximity_auth.css View 1 chunk +1 line, -9 lines 0 comments Download
M components/proximity_auth/webui/resources/proximity_auth.html View 1 chunk +1 line, -0 lines 0 comments Download
A ui/webui/resources/css/roboto.css View 1 2 1 chunk +23 lines, -0 lines 0 comments Download
D ui/webui/resources/roboto/roboto.woff View Binary file 0 comments Download
D ui/webui/resources/roboto/roboto.woff2 View Binary file 0 comments Download
A ui/webui/resources/roboto/roboto-medium-latin.woff2 View Binary file 0 comments Download
A ui/webui/resources/roboto/roboto-regular-latin.woff2 View Binary file 0 comments Download
M ui/webui/resources/webui_resources.grd View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (9 generated)
tsergeant
raymes@, please review changes in chromes/browser/resources/pdf/ isherman@, please review changes in components/proximity_auth michaelpg@, please review ...
5 years, 7 months ago (2015-05-19 03:11:42 UTC) #2
Ilya Sherman
proximity_auth lgtm (+Tim as an FYI)
5 years, 7 months ago (2015-05-19 03:15:59 UTC) #3
michaelpg
https://codereview.chromium.org/1142893002/diff/20001/ui/webui/resources/css/roboto.css File ui/webui/resources/css/roboto.css (right): https://codereview.chromium.org/1142893002/diff/20001/ui/webui/resources/css/roboto.css#newcode4 ui/webui/resources/css/roboto.css:4: @font-face { nit: newline above declaration block https://codereview.chromium.org/1142893002/diff/20001/ui/webui/resources/css/roboto.css#newcode10 ui/webui/resources/css/roboto.css:10: ...
5 years, 7 months ago (2015-05-19 03:21:57 UTC) #4
tsergeant
https://codereview.chromium.org/1142893002/diff/20001/ui/webui/resources/css/roboto.css File ui/webui/resources/css/roboto.css (right): https://codereview.chromium.org/1142893002/diff/20001/ui/webui/resources/css/roboto.css#newcode4 ui/webui/resources/css/roboto.css:4: @font-face { On 2015/05/19 03:21:57, michaelpg wrote: > nit: ...
5 years, 7 months ago (2015-05-19 03:36:00 UTC) #5
michaelpg
lgtm https://codereview.chromium.org/1142893002/diff/20001/ui/webui/resources/css/roboto.css File ui/webui/resources/css/roboto.css (right): https://codereview.chromium.org/1142893002/diff/20001/ui/webui/resources/css/roboto.css#newcode10 ui/webui/resources/css/roboto.css:10: unicode-range: U+0000-00FF, U+0131, U+0152-0153, U+02C6, U+02DA, U+02DC, On ...
5 years, 7 months ago (2015-05-19 07:21:27 UTC) #6
Mathieu
lgtm (+pedro fyi)
5 years, 7 months ago (2015-05-19 13:51:41 UTC) #7
James Hawkins
lgtm
5 years, 7 months ago (2015-05-19 15:25:19 UTC) #9
raymes
lgtm
5 years, 7 months ago (2015-05-19 23:54:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142893002/40001
5 years, 7 months ago (2015-05-20 00:21:57 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/64786)
5 years, 7 months ago (2015-05-20 00:32:16 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142893002/60001
5 years, 7 months ago (2015-05-20 00:58:13 UTC) #20
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-20 03:34:52 UTC) #21
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 03:35:37 UTC) #22
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/52eb6dd02c535873dda638dcd5e08e1fc7af5538
Cr-Commit-Position: refs/heads/master@{#330689}

Powered by Google App Engine
This is Rietveld 408576698