Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1142873005: [turbofan] Fix over-restictive assertion in code generator. (Closed)

Created:
5 years, 7 months ago by Michael Starzinger
Modified:
5 years, 7 months ago
Reviewers:
titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix over-restictive assertion in code generator. R=titzer@chromium.org TEST=mjsunit/regress/regress-crbug-489293 BUG=chromium:489293 LOG=n Committed: https://crrev.com/7bd2d3e32ebbfeb439d5e58b5c0f06ab62723ba9 Cr-Commit-Position: refs/heads/master@{#28486}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -11 lines) Patch
M src/compiler/code-generator.cc View 1 chunk +1 line, -4 lines 0 comments Download
A + test/mjsunit/regress/regress-crbug-489293.js View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 7 months ago (2015-05-19 15:04:52 UTC) #1
titzer
lgtm
5 years, 7 months ago (2015-05-19 15:09:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142873005/1
5 years, 7 months ago (2015-05-19 16:13:04 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 16:14:57 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 16:15:01 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bd2d3e32ebbfeb439d5e58b5c0f06ab62723ba9
Cr-Commit-Position: refs/heads/master@{#28486}

Powered by Google App Engine
This is Rietveld 408576698