Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(833)

Issue 1142863002: Remove support for custom menu items in context menus. (Closed)

Created:
5 years, 7 months ago by aurimas (slooooooooow)
Modified:
5 years, 7 months ago
Reviewers:
Ted C, newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove support for custom menu items in context menus. Custom menu items where used for WebUI NTP and is no longer used. This CL removes support for such menus. BUG=None Committed: https://crrev.com/b7931b4dec4529327e5c3a51bf59ece6a39e0dbe Cr-Commit-Position: refs/heads/master@{#330412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -109 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuHelper.java View 4 chunks +4 lines, -22 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ContextMenuParams.java View 4 chunks +0 lines, -53 lines 0 comments Download
M chrome/browser/ui/android/context_menu_helper.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/ui/android/context_menu_helper.cc View 2 chunks +0 lines, -26 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
aurimas (slooooooooow)
PTAL
5 years, 7 months ago (2015-05-18 18:42:46 UTC) #2
newt (away)
lgtm
5 years, 7 months ago (2015-05-18 18:53:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142863002/1
5 years, 7 months ago (2015-05-18 18:55:54 UTC) #5
aurimas (slooooooooow)
tedchoc: PTAL at chrome/browser/ui/android/*
5 years, 7 months ago (2015-05-18 20:23:57 UTC) #8
Ted C
lgtm
5 years, 7 months ago (2015-05-18 20:35:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142863002/1
5 years, 7 months ago (2015-05-18 20:44:14 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 20:50:39 UTC) #12
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:42:55 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b7931b4dec4529327e5c3a51bf59ece6a39e0dbe
Cr-Commit-Position: refs/heads/master@{#330412}

Powered by Google App Engine
This is Rietveld 408576698