net: Make TestCompletionCallback use RunLoops.

net:  Make TestCompletionCallback use RunLoops.

This is more robust against re-entrantly run MessageLoops.

BUG=none

Committed: https://crrev.com/31c4e0a19d35dd3c53b764bf2c6b42c25b2eaccf
Cr-Commit-Position: refs/heads/master@{#330825}

[mmenke, 2015-05-20 17:37:04]

mmenke@chromium.org changed reviewers:
+ rch@chromium.org

[mmenke, 2015-05-20 17:37:05]

This was inspired by your socket cleanups, and thinking about switching stuff
over from using DeterministicSocketData.

Not a huge CL, but I had to land https://codereview.chromium.org/1132313004/ to
get this working.

https://codereview.chromium.org/1142843002/diff/80001/net/base/test_completio...
File net/base/test_completion_callback.cc (right):

https://codereview.chromium.org/1142843002/diff/80001/net/base/test_completio...
net/base/test_completion_callback.cc:32: // TODO(mmenke):  We really should fix
this.
Note that 300+ tests depend on this - mostly SPDY and HttpCache tests, so may be
more effort than it's worth.

[Ryan Hamilton, 2015-05-20 22:43:48]

LGTM

Thanks for fixing this!

https://codereview.chromium.org/1142843002/diff/80001/net/base/test_completio...
File net/base/test_completion_callback.cc (right):

https://codereview.chromium.org/1142843002/diff/80001/net/base/test_completio...
net/base/test_completion_callback.cc:32: // TODO(mmenke):  We really should fix
this.
On 2015/05/20 17:37:05, mmenke wrote:
> Note that 300+ tests depend on this - mostly SPDY and HttpCache tests, so may
be
> more effort than it's worth.

Oy!

[mmenke, 2015-05-20 22:47:01]

The CQ bit was checked by mmenke@chromium.org

[commit-bot: I haz the power, 2015-05-20 22:50:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1142843002/80001

[commit-bot: I haz the power, 2015-05-20 22:57:32]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2015-05-20 22:59:21]

Patchset 5 (id:??) landed as
https://crrev.com/31c4e0a19d35dd3c53b764bf2c6b42c25b2eaccf
Cr-Commit-Position: refs/heads/master@{#330825}