Remove bundling from the MCAssembler interface

Remove bundling from the MCAssembler interface

A preparatory stage towards cleanly separating bundling for upstreaming.

BUG= http://code.google.com/p/nativeclient/issues/detail?id=3178

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=764bddd

[sehr, 2012-12-04 22:45:23]

A small cleanup prior to more fiddling with bundling.

[eliben, 2012-12-05 00:01:34]

https://codereview.chromium.org/11428170/diff/1/lib/MC/MCAssembler.cpp
File lib/MC/MCAssembler.cpp (right):

https://codereview.chromium.org/11428170/diff/1/lib/MC/MCAssembler.cpp#newcod...
lib/MC/MCAssembler.cpp:499: uint64_t AddressToBundlePadding(uint64_t Address,
uint64_t BundleMask) {
Why was static removed?

https://codereview.chromium.org/11428170/diff/1/lib/MC/MCAssembler.cpp#newcod...
lib/MC/MCAssembler.cpp:503: uint64_t ComputeNaClAlignMask(uint64_t
NaClAlignSize) {
static?

https://codereview.chromium.org/11428170/diff/1/lib/MC/MCAssembler.cpp#newcod...
lib/MC/MCAssembler.cpp:503: uint64_t ComputeNaClAlignMask(uint64_t
NaClAlignSize) {
why the change s/bundle/nacl/ here? Would we not want to go in the other
direction

[sehr, 2012-12-05 00:11:05]

Thanks.  New version uploaded.  PTAL.

https://chromiumcodereview.appspot.com/11428170/diff/1/lib/MC/MCAssembler.cpp
File lib/MC/MCAssembler.cpp (right):

https://chromiumcodereview.appspot.com/11428170/diff/1/lib/MC/MCAssembler.cpp...
lib/MC/MCAssembler.cpp:499: uint64_t AddressToBundlePadding(uint64_t Address,
uint64_t BundleMask) {
On 2012/12/05 00:01:34, eliben wrote:
> Why was static removed?

Added back, per the coding conventions.

https://chromiumcodereview.appspot.com/11428170/diff/1/lib/MC/MCAssembler.cpp...
lib/MC/MCAssembler.cpp:503: uint64_t ComputeNaClAlignMask(uint64_t
NaClAlignSize) {
On 2012/12/05 00:01:34, eliben wrote:
> static?

Done.

https://chromiumcodereview.appspot.com/11428170/diff/1/lib/MC/MCAssembler.cpp...
lib/MC/MCAssembler.cpp:503: uint64_t ComputeNaClAlignMask(uint64_t
NaClAlignSize) {
On 2012/12/05 00:01:34, eliben wrote:
> why the change s/bundle/nacl/ here? Would we not want to go in the other
> direction

Reverted, per your suggestion.

[eliben, 2012-12-05 00:20:43]

lgtm