Issue 11428161: bookmarks: Break the dependency in ui/cocoa.

Issue 11428161: bookmarks: Break the dependency in ui/cocoa. (Closed)

Created:
8 years ago by tfarina

Modified:
8 years ago

Reviewers:
mrossetti, sail, sky

CC:
chromium-reviews, browser-components-watch_chromium.org, dcheng, sail+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

bookmarks: Break the dependency in ui/cocoa. BUG=144783 R=sky@chromium.org,mrossetti@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171221

Patch Set 2 : forgot to add bookmark_drag_drop.h #

Patch Set 4 : fix2 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -194 lines)			Patch
M	chrome/browser/bookmarks/DEPS	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.h	View		2 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/bookmarks/bookmark_pasteboard_helper_mac.mm	View	1 2	3 chunks	+0 lines, -152 lines	0 comments	Download
A	chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.h	View	1	1 chunk	+23 lines, -0 lines	0 comments	Download
D	chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.cc	View		1 chunk	+0 lines, -25 lines	0 comments	Download
A	chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm	View	1 2 3	1 chunk	+190 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/cocoa/location_bar/location_icon_decoration.mm	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/chrome_browser_ui.gypi	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

tfarina

Please, take a look. https://codereview.chromium.org/11428161/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm (right): https://codereview.chromium.org/11428161/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm#newcode143 chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm:143: std::vector<BookmarkNodeData::Element> elements; I fold the ...

8 years ago (2012-12-04 16:15:53 UTC) #1

sail

cocoa/* LGTM Thanks for doing this! https://codereview.chromium.org/11428161/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm (right): https://codereview.chromium.org/11428161/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm#newcode24 chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm:24: namespace chrome { ...

8 years ago (2012-12-04 16:34:13 UTC) #2

tfarina

https://codereview.chromium.org/11428161/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm File chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm (right): https://codereview.chromium.org/11428161/diff/1/chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm#newcode24 chrome/browser/ui/cocoa/bookmarks/bookmark_drag_drop.mm:24: namespace chrome { On 2012/12/04 16:34:13, sail wrote: > ...

8 years ago (2012-12-04 16:39:48 UTC) #3

sail

8 years ago (2012-12-04 16:41:50 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11428161/9001

8 years ago (2012-12-05 10:55:19 UTC) #6

Message was sent while issue was closed.

Change committed as 171221

Expand Messages | Collapse Messages