LoadTiming implementation in net, part 1.

net/socket/connect_timing.h

Index: net/socket/connect_timing.h
===================================================================
--- net/socket/connect_timing.h	(revision 0)
+++ net/socket/connect_timing.h	(revision 0)
@@ -0,0 +1,33 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_SOCKET_CONNECT_TIMING_H_
+#define NET_SOCKET_CONNECT_TIMING_H_
+
+#include "base/basictypes.h"
+#include "base/time.h"
+#include "net/base/net_export.h"
+
+namespace net {
+
+// Contains the LoadTimingInfo events related to establishing a connection.
+// These are all set by ConnectJobs.  See base/load_timing.h for field

[eroman, 2013/01/05 00:30:15]

Do you think it is worth combining these guys using either composition or
inheritance? (i.e. LoadTimingInfo contains a ConnectTiming field).

[mmenke, 2013/01/05 03:53:13]

I've gone back and forth on this:  The main reason it's a separate class is
because LoadTiming is an externally visible class, and ConnectTiming can live
only in net.

That having been said, if we moved ConnectTiming to LoadTiming.h, I'm perfectly
happy to unify them.  I don't think embedders should have to deal with fairly
complicated documentation split between two files.

Initially I was planning to avoid distinction between these times in
LoadTiming.h, but now that we're doing so, I think it's reasonable to make the
separate class externally visible.

Because of the distinction, I think composition is preferable.  I'll go ahead
and do that, making it a public inner class of LoadTiming.  If you think a
different approach is preferable, I'm happy to adjust.

+// descriptions.
+struct NET_EXPORT_PRIVATE ConnectTiming {
+  ConnectTiming();
+  ~ConnectTiming();
+
+  base::TimeTicks dns_start;
+  base::TimeTicks dns_end;
+
+  base::TimeTicks connect_start;
+  base::TimeTicks connect_end;
+
+  base::TimeTicks ssl_start;
+  base::TimeTicks ssl_end;
+};
+
+}  // namespace net
+
+#endif  // NET_SOCKET_CONNECT_TIMING_H_
Property changes on: net\socket\connect_timing.h
___________________________________________________________________
Added: svn:eol-style
   + LF