LoadTiming implementation in net, part 1.

net/socket/ssl_client_socket_pool.cc

Index: net/socket/ssl_client_socket_pool.cc
===================================================================
--- net/socket/ssl_client_socket_pool.cc	(revision 172981)
+++ net/socket/ssl_client_socket_pool.cc	(working copy)
@@ -129,7 +129,7 @@
         transport_socket_handle_.release());
   }
   handle->set_ssl_error_response_info(error_response_info_);
-  if (!ssl_connect_start_time_.is_null())
+  if (!connect_timing().ssl_start.is_null())
     handle->set_is_ssl_error(true);
 }
 
@@ -259,8 +259,20 @@
   next_state_ = STATE_SSL_CONNECT_COMPLETE;
   // Reset the timeout to just the time allowed for the SSL handshake.
   ResetTimer(base::TimeDelta::FromSeconds(kSSLHandshakeTimeoutInSeconds));
-  ssl_connect_start_time_ = base::TimeTicks::Now();
 
+  // If the handle has a fresh socket, get its connect start and DNS times.
+  // This is currently always be the case.
+  const ConnectTiming& socket_connect_timing =
+      transport_socket_handle_->connect_timing();
+  if (!transport_socket_handle_->is_reused() &&
+      !socket_connect_timing.connect_start.is_null()) {
+    connect_timing().connect_start = socket_connect_timing.connect_start;
+    connect_timing().dns_start = socket_connect_timing.dns_start;
+    connect_timing().dns_end = socket_connect_timing.dns_end;

[eroman, 2012/12/14 04:08:35]

can you access it directly instead? (i.e. make the field protected or
something).

[mmenke, 2012/12/14 13:36:12]

Done.

+  }
+
+  connect_timing().ssl_start = base::TimeTicks::Now();
+
   ssl_socket_.reset(client_socket_factory_->CreateSSLClientSocket(
       transport_socket_handle_.release(), params_->host_and_port(),
       params_->ssl_config(), context_));
@@ -268,6 +280,8 @@
 }
 
 int SSLConnectJob::DoSSLConnectComplete(int result) {
+  connect_timing().ssl_end = base::TimeTicks::Now();
+
   SSLClientSocket::NextProtoStatus status =
       SSLClientSocket::kNextProtoUnsupported;
   std::string proto;
@@ -302,9 +316,9 @@
 
   if (result == OK ||
       ssl_socket_->IgnoreCertError(result, params_->load_flags())) {
-    DCHECK(ssl_connect_start_time_ != base::TimeTicks());
+    DCHECK(connect_timing().ssl_start != base::TimeTicks());

[eroman, 2012/12/14 04:08:35]

!x.is_null() ?

[mmenke, 2012/12/14 13:36:12]

Done.

     base::TimeDelta connect_duration =
-        base::TimeTicks::Now() - ssl_connect_start_time_;
+        connect_timing().ssl_end - connect_timing().ssl_start;
     if (using_spdy) {
       UMA_HISTOGRAM_CUSTOM_TIMES("Net.SpdyConnectionLatency",
                                  connect_duration,