src/arm/lithium-codegen-arm.cc - Issue 11428137: ARM: Make use of d16-d31 when available.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 11428137: ARM: Make use of d16-d31 when available. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use an ExternalReference to check CpuFeatures in generated code Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 8897b63ebdf8e704811fd9511a8f2e1a09e9e308..6ce76838ce125e0fabf6d549e154b9e6d5c52eaf 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -3177,8 +3177,8 @@ void LCodeGen::DoLoadKeyedExternalArray(LLoadKeyed* instr) {

if (CpuFeatures::IsSupported(VFP2)) {

CpuFeatures::Scope scope(VFP2);

if (elements_kind == EXTERNAL_FLOAT_ELEMENTS) {

- __ vldr(result.low(), scratch0(), additional_offset);

- __ vcvt_f64_f32(result, result.low());

+ __ vldr(kScratchDoubleReg.low(), scratch0(), additional_offset);

+ __ vcvt_f64_f32(result, kScratchDoubleReg.low());

} else { // i.e. elements_kind == EXTERNAL_DOUBLE_ELEMENTS

__ vldr(result, scratch0(), additional_offset);

}