Added a basic WebRTC peerconnection browser test with video verification.

content/browser/webrtc_getusermedia_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/utf_string_conversions.h"
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/shell/shell.h"
 #include "content/test/content_browser_test.h"
 #include "content/test/content_browser_test_utils.h"
 #include "net/test/test_server.h"
 
 namespace content {
 
 // Tests The WebRTC getUserMedia call.
 // Note: Requires --use-fake-device-for-media-stream (this flag is set by
 // default in content_browsertests).
 class WebrtcGetUserMediaTest: public ContentBrowserTest {
  public:
   WebrtcGetUserMediaTest() {}
+
+  virtual void SetUp() OVERRIDE {
+    ASSERT_TRUE(test_server()->Start());
+    ContentBrowserTest::SetUp();
+  }
+
+  virtual void TearDown() OVERRIDE {
+    ContentBrowserTest::TearDown();
+    ASSERT_TRUE(test_server()->Stop());

[jam, 2012/12/03 15:55:54]

test_server's destructor already calls Stop(), so no need to override this
method

[phoglund_chromium, 2012/12/03 17:34:51]

Done.

+  }
  protected:
-  void TestGetUserMediaWithConstraints(const std::string& constraints) {
-    ASSERT_TRUE(test_server()->Start());
-    GURL empty_url(test_server()->GetURL(
-        "files/media/getusermedia_and_stop.html"));
-    NavigateToURL(shell(), empty_url);
-
+  bool ExecuteJavascript(const std::string& javascript) {
     RenderViewHost* render_view_host =
         shell()->web_contents()->GetRenderViewHost();
 
-    EXPECT_TRUE(ExecuteJavaScript(render_view_host, L"",
-                                  ASCIIToWide(constraints)));
-
-    ExpectTitle("OK");
+    return ExecuteJavaScript(render_view_host, L"", ASCIIToWide(javascript));
   }
 
   void ExpectTitle(const std::string& expected_title) const {
     string16 expected_title16(ASCIIToUTF16(expected_title));
     TitleWatcher title_watcher(shell()->web_contents(), expected_title16);
     EXPECT_EQ(expected_title16, title_watcher.WaitAndGetTitle());
   }
 };
 
 // These tests will all make a getUserMedia call with different constraints and
 // see that the success callback is called. If the error callback is called or
 // none of the callbacks are called the tests will simply time out and fail.
 IN_PROC_BROWSER_TEST_F(WebrtcGetUserMediaTest, GetVideoStreamAndStop) {

[phoglund_chromium, 2012/12/03 14:25:08]

I think this way of organizing the test made a bit more sense. There's a tiny
bit more duplication but the tests are easier to understand.

[jam, 2012/12/03 15:55:54]

to me they're both as easy to understand, but if you really like this, then ok

[phoglund_chromium, 2012/12/03 17:34:51]

Yeah, I think we will go in a direction where we make several javascript calls
in a row soon, so I think this looks about right.

-  TestGetUserMediaWithConstraints("getUserMedia({video: true});");
+  GURL url(test_server()->GetURL("files/media/getusermedia_and_stop.html"));
+  NavigateToURL(shell(), url);
+
+  EXPECT_TRUE(ExecuteJavascript("getUserMedia({video: true});"));
+
+  ExpectTitle("OK");
 }
 
 IN_PROC_BROWSER_TEST_F(WebrtcGetUserMediaTest, GetAudioAndVideoStreamAndStop) {
-  TestGetUserMediaWithConstraints("getUserMedia({video: true, audio: true});");
-}
+  GURL url(test_server()->GetURL("files/media/getusermedia_and_stop.html"));
+  NavigateToURL(shell(), url);
 
-// TODO(phoglund): enable once we have fake audio device support.
-IN_PROC_BROWSER_TEST_F(WebrtcGetUserMediaTest, DISABLED_GetAudioStreamAndStop) {
-  TestGetUserMediaWithConstraints("getUserMedia({audio: true});");
+  EXPECT_TRUE(ExecuteJavascript("getUserMedia({video: true, audio: true});"));
+
+  ExpectTitle("OK");
 }
 
 }  // namespace content