Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2269)

Unified Diff: chrome/browser/resources/chromeos/login/network_dropdown.js

Issue 11428124: Improve accessible markup of OOBE network drop-down. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/login/network_dropdown.js
diff --git a/chrome/browser/resources/chromeos/login/network_dropdown.js b/chrome/browser/resources/chromeos/login/network_dropdown.js
index 4ed6b47d79b7ae52ae23429fa714880c8d10672c..bfe69d22120262479291c12cd75f419dfbe6965e 100644
--- a/chrome/browser/resources/chromeos/login/network_dropdown.js
+++ b/chrome/browser/resources/chromeos/login/network_dropdown.js
@@ -93,13 +93,16 @@ cr.define('cr.ui', function() {
decorate: function() {
this.appendChild(this.createOverlay_());
this.appendChild(this.title_ = this.createTitle_());
- this.appendChild(new DropDownContainer());
+ var container = new DropDownContainer();
+ container.id = this.id + '-dropdown-container';
+ this.appendChild(container);
this.addEventListener('keydown', this.keyDownHandler_);
this.title_.id = this.id + '-dropdown';
this.title_.setAttribute('role', 'button');
this.title_.setAttribute('aria-haspopup', 'true');
+ this.title_.setAttribute('aria-owns', container.id);
},
/**
@@ -119,9 +122,7 @@ cr.define('cr.ui', function() {
this.container.hidden = !show;
if (show) {
this.container.selectItem(this.container.firstItem, false);
- this.title_.setAttribute('aria-pressed', 'true');
} else {
- this.title_.setAttribute('aria-pressed', 'false');
this.title_.removeAttribute('aria-activedescendant');
}
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698