Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issue 11428124: Improve accessible markup of OOBE network drop-down. (Closed)

Created:
8 years ago by dmazzoni
Modified:
8 years ago
CC:
chromium-reviews, arv (Not doing code reviews), stevenjb+watch_chromium.org, oshima+watch_chromium.org, dcheng, nkostylev+watch_chromium.org
Visibility:
Public.

Description

Improve accessible markup of OOBE network drop-down. BUG=161880 TBR=nkostylev Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170977

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M chrome/browser/resources/chromeos/login/network_dropdown.js View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
dmazzoni
8 years ago (2012-12-01 00:07:14 UTC) #1
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years ago (2012-12-03 21:57:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dmazzoni@chromium.org/11428124/1
8 years ago (2012-12-03 22:02:07 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) chrome_frame_net_tests, chrome_frame_unittests, content_browsertests, installer_util_unittests, mini_installer_test, nacl_integration, ...
8 years ago (2012-12-04 02:04:51 UTC) #4
dmazzoni
On Fri, Nov 30, 2012 at 5:16 PM, David Tseng <dtseng@chromium.org> wrote: > + this.title_.setAttribute('aria-owns', ...
8 years ago (2012-12-04 08:56:10 UTC) #5
Nikita (slow)
8 years ago (2012-12-04 16:46:02 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698