Issue 11428122: Let content_unittests almost build with the components build on android

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11428122: Let content_unittests almost build with the components build on android (Closed)

Created:
8 years ago by Nico

Modified:
8 years ago

Reviewers:
Yaron, Ami GONE FROM CHROMIUM

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org

Base URL:
http://git.chromium.org/git/chromium.git@trunk

Visibility:
Public.

Let content_unittests almost build with the components build on android BUG=158821 TBR=fischman Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170586

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+32 lines, -19 lines)			Patch
M	content/browser/android/browser_jni_registrar.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/browser/renderer_host/java/java_bound_object.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/common/android/address_parser.h	View	2 chunks	+5 lines, -4 lines	0 comments	Download
M	content/common/android/address_parser_internal.h	View	4 chunks	+14 lines, -10 lines	0 comments	Download
M	content/common/android/common_jni_registrar.h	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	content/renderer/android/email_detector.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	content/renderer/android/phone_number_detector.h	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	media/audio/android/audio_manager_android.h	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

Nico

If I comment out the NPAPI_MemAlloc() call mentioned in the CL, content_unittests build for me ...

8 years ago (2012-11-30 22:43:20 UTC) #1

Yaron

That's one issue that I have remaining and haven't solved. The other is when commenting ...

8 years ago (2012-11-30 22:47:21 UTC) #2

Nico

8 years ago (2012-11-30 23:02:10 UTC) #4

fischman: Please stamp the media/audio change. This makes android match the
other ports with a components build.