Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1222)

Unified Diff: content/browser/web_contents/navigation_controller_impl.cc

Issue 11428119: Merge 167856 - Ensure a transient entry is discarded on in-page navigations. (Closed) Base URL: svn://svn.chromium.org/chrome/branches/1271/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/navigation_controller_impl.cc
===================================================================
--- content/browser/web_contents/navigation_controller_impl.cc (revision 170535)
+++ content/browser/web_contents/navigation_controller_impl.cc (working copy)
@@ -983,8 +983,7 @@
//
// Note that we need to use the "internal" version since we don't want to
// actually change any other state, just kill the pointer.
- if (pending_entry_)
- DiscardNonCommittedEntriesInternal();
+ DiscardNonCommittedEntriesInternal();
// If a transient entry was removed, the indices might have changed, so we
// have to query the entry index again.
@@ -1032,8 +1031,7 @@
// This replaces the existing entry since the page ID didn't change.
*did_replace_entry = true;
- if (pending_entry_)
- DiscardNonCommittedEntriesInternal();
+ DiscardNonCommittedEntriesInternal();
// If a transient entry was removed, the indices might have changed, so we
// have to query the entry index again.
« no previous file with comments | « no previous file | content/browser/web_contents/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698