Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: tools/telemetry/telemetry/page_runner.py

Issue 11428107: Telemetry: extends Platform abstraction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Platform API Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/page_runner.py
diff --git a/tools/telemetry/telemetry/page_runner.py b/tools/telemetry/telemetry/page_runner.py
index b2268e201cf131908a25a8f33e65c0aff0c1f1a8..1d633f66c885acb9bfab86924f3304541fc9749f 100644
--- a/tools/telemetry/telemetry/page_runner.py
+++ b/tools/telemetry/telemetry/page_runner.py
@@ -35,9 +35,13 @@ class _RunState(object):
self.tab = None
if self.browser:
+ if self.browser.platform.CanMonitorThermalThrottling():
nduca 2012/12/07 18:12:06 this check should be somewhere else--- probably af
bulach 2012/12/07 20:45:53 good point, done. raising an exception at the end
+ self.browser.platform.StopMonitoringThermalThrottling()
+ self.browser.platform.SetFullPerformanceModeEnabled(False)
nduca 2012/12/07 18:12:06 this should be conditional on performance tests be
bulach 2012/12/07 20:45:53 Done.
self.browser.Close()
self.browser = None
+
def _ShufflePageSet(page_set, options):
if options.test_shuffle_order_file and not options.test_shuffle:
raise Exception('--test-shuffle-order-file requires --test-shuffle.')
@@ -117,6 +121,9 @@ http://goto/read-src-internal, or create a new archive using --record.
if not state.browser:
self._SetupBrowser(state, test, possible_browser,
credentials_path, archive_path)
+ state.browser.platform.SetFullPerformanceModeEnabled(True)
nduca 2012/12/07 18:12:06 so should this
nduca 2012/12/07 18:12:06 why not inside _SetupBrowser?
bulach 2012/12/07 20:45:53 Done.
+ if state.browser.platform.CanMonitorThermalThrottling():
+ state.browser.platform.StartMonitoringThermalThrottling()
if not state.tab:
state.tab = state.browser.ConnectToNthTab(0)
if options.trace_dir:

Powered by Google App Engine
This is Rietveld 408576698