Telemetry: extends Platform abstraction.

tools/telemetry/telemetry/browser_options.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import optparse
 import sys
 import shlex
 import logging
 import copy
 
 from telemetry import browser_finder
@@ skipping 57 matching lines @@
     group.add_option(
         '--remote',
         dest='cros_remote',
         help='The IP address of a remote ChromeOS device to use.')
     group.add_option('--identity',
         dest='cros_ssh_identity',
         default=None,
         help='The identity file to use when ssh\'ing into the ChromeOS device')
     parser.add_option_group(group)
 
+    # Benchmark options
+    group = optparse.OptionGroup(parser, 'Benchmark options')
+    group.add_option('--performance-test', action='store_true',

[tonyg, 2013/02/21 18:07:08]

Why is this an option? Shouldn't we just do this by default? If we need a way to
disable it for some use-case, then I'd recommend flipping this flag to default
to true.

[bulach, 2013/02/22 11:54:25]

good point, removed..

+        dest='performance_test',
+        help='Run the benchmark in full power mode (if the underlying platform '
+             'supports).')
+
     # Browser options
     group = optparse.OptionGroup(parser, 'Browser options')
     group.add_option('--dont-override-profile', action='store_true',
         dest='dont_override_profile',
         help='Uses the regular user profile instead of a clean one')
     group.add_option('--extra-browser-args',
         dest='extra_browser_args_as_string',
         help='Additional arguments to pass to the browser when it starts')
     group.add_option('--show-stdout',
         action='store_true',
@@ skipping 59 matching lines @@
           self.extra_browser_args_as_string) # pylint: disable=E1101
         self.extra_browser_args.extend(tmp)
         delattr(self, 'extra_browser_args_as_string')
       return ret
     parser.parse_args = ParseArgs
     return parser
 
   def AppendExtraBrowserArg(self, arg):
     if arg not in self.extra_browser_args:
       self.extra_browser_args.append(arg)