Telemetry: extends Platform abstraction.

tools/telemetry/telemetry/android_platform_backend.py

+# Copyright (c) 2012 The Chromium Authors. All rights reserved.

[tonyg, 2013/02/21 18:07:08]

You can update to 2013 now. Boo for long reviews.

[bulach, 2013/02/22 11:54:25]

++year! :)

+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+import os
+import sys
+
+# Get build/android scripts into our path.
+sys.path.append(
+    os.path.abspath(
+        os.path.join(os.path.dirname(__file__),
+                     '../../../build/android')))
+
+from pylib import perf_tests_helper # pylint: disable=F0401

[tonyg, 2013/02/21 18:07:08]

2 spaces between code and comments

[bulach, 2013/02/22 11:54:25]

Done.

+from pylib import thermal_throttle # pylint: disable=F0401
+
+try:
+  from pylib import surface_stats_collector # pylint: disable=F0401
+except Exception:
+  surface_stats_collector = None
+
+
+class AndroidPlatformBackend(object):
+  def __init__(self, adb, window_package, window_activity):
+    super(AndroidPlatformBackend, self).__init__()
+    self._adb = adb
+    self._window_package = window_package
+    self._window_activity = window_activity
+    self._surface_stats_collector = None
+    self._perf_tests_setup = perf_tests_helper.PerfTestSetup(adb)
+    self._thermal_throttle = thermal_throttle.ThermalThrottle(self._adb)

[tonyg, 2013/02/21 18:07:08]

This uses adb as one arg and self._adb as the other. Please be consistent.

[bulach, 2013/02/22 11:54:25]

Done.

+
+  def IsRawDisplayFrameRateSupported(self):
+    return True
+
+  def StartRawDisplayFrameRateMeasurement(self, trace_tag):
+    assert not self._surface_stats_collector
+    self._surface_stats_collector = \
+        surface_stats_collector.SurfaceStatsCollector(
+            self._adb, self._window_package, self._window_activity, trace_tag)
+    self._surface_stats_collector.__enter__()
+
+  def StopRawDisplayFrameRateMeasurement(self):
+    self._surface_stats_collector.__exit__()
+    self._surface_stats_collector = None
+
+  def SetFullPerformanceModeEnabled(self, enabled):
+    if enabled:
+      self._perf_tests_setup.SetUp()
+    else:
+      self._perf_tests_setup.TearDown()
+
+  def CanMonitorThermalThrottling(self):
+    return True
+
+  def IsThermallyThrottled(self):

[aberent, 2013/01/29 14:03:36]

This asks whether the device is currently thermally throttled. This makes sense
before you start a test, but what you really need to ask is whether the device
was thermally throttled at any time during the test. If it is you should ignore
the test result, give the device time to cool down, and then rerun the test.
Since you presumably can't continuously run IsThermallyThrottled while the test
is running you need to do this by looking for log messages over a known period.

[bulach, 2013/02/22 11:54:25]

good point! added a "HasBeenThrottled" and changed the checks..

+    return self._thermal_throttle.IsThrottled()