Telemetry: extends Platform abstraction.

tools/telemetry/telemetry/page_runner.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import logging
 import os
 import time
 import traceback
 import urlparse
 import random
 
@@ skipping 17 matching lines @@
   def Close(self):
     if self.trace_tab:
       self.trace_tab.Close()
       self.trace_tab = None
 
     if self.tab:
       self.tab.Close()
       self.tab = None
 
     if self.browser:
+      if self.browser.platform.CanMonitorThermalThrottling():

[nduca, 2012/12/07 18:12:06]

this check should be somewhere else--- probably after each page runs, you should
check for thermal monitoring and as noted in the previous discussion, mark it as
failing, no?

[bulach, 2012/12/07 20:45:53]

good point, done. raising an exception at the end of the test, we may want to
revisit it later..

+        self.browser.platform.StopMonitoringThermalThrottling()
+      self.browser.platform.SetFullPerformanceModeEnabled(False)

[nduca, 2012/12/07 18:12:06]

this should be conditional on performance tests being true

[bulach, 2012/12/07 20:45:53]

Done.

       self.browser.Close()
       self.browser = None
 
+
 def _ShufflePageSet(page_set, options):
   if options.test_shuffle_order_file and not options.test_shuffle:
     raise Exception('--test-shuffle-order-file requires --test-shuffle.')
 
   if options.test_shuffle_order_file:
     return page_set.ReorderPageSet(options.test_shuffle_order_file)
 
   pages = page_set.pages[:]
   if options.test_shuffle:
     random.Random().shuffle(pages)
@@ skipping 59 matching lines @@
 
     state = _RunState()
     try:
       for page in pages:
         tries = 3
         while tries:
           try:
             if not state.browser:
               self._SetupBrowser(state, test, possible_browser,
                                  credentials_path, archive_path)
+              state.browser.platform.SetFullPerformanceModeEnabled(True)

[nduca, 2012/12/07 18:12:06]

so should this

[nduca, 2012/12/07 18:12:06]

why not inside _SetupBrowser?

[bulach, 2012/12/07 20:45:53]

Done.

+              if state.browser.platform.CanMonitorThermalThrottling():
+                state.browser.platform.StartMonitoringThermalThrottling()
             if not state.tab:
               state.tab = state.browser.ConnectToNthTab(0)
             if options.trace_dir:
               self._SetupTracingTab(state)
 
             try:
               self._RunPage(options, page, state.tab, test, results)
             except tab_crash_exception.TabCrashException:
               # If we don't support tab control, just restart the browser.
               # TODO(dtu): Create a new tab: crbug.com/155077, crbug.com/159852
@@ skipping 176 matching lines @@
     return True
 
   def _CleanUpPage(self, page, tab, page_state): # pylint: disable=R0201
     if page.credentials and page_state.did_login:
       tab.browser.credentials.LoginNoLongerNeeded(tab, page.credentials)
     try:
       tab.runtime.Evaluate("""window.chrome && chrome.benchmarking &&
                               chrome.benchmarking.closeConnections()""")
     except Exception:
       pass