Telemetry: extends Platform abstraction.

tools/telemetry/telemetry/multi_page_benchmark_runner.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 import csv
 import logging
 import os
 import sys
 
 from telemetry import all_page_interactions # pylint: disable=W0611
@@ skipping 58 matching lines @@
   if options.output_format == 'csv':
     results = multi_page_benchmark.CsvBenchmarkResults(csv.writer(sys.stdout))
   elif options.output_format == 'terminal-block':
     results = multi_page_benchmark.TerminalBlockBenchmarkResults(sys.stdout)
   else:
     raise Exception('Invalid --output-format value: "%s". Valid values are '
                     '"csv" and "terminal-block".'
                     % options.output_format)
 
   with page_runner.PageRunner(ps) as runner:
     runner.Run(options, possible_browser, benchmark, results)

[nduca, 2012/12/07 18:12:06]

pass in performance_test=True to runner or put on the options object

[bulach, 2012/12/07 20:45:53]

Done as an option

+
   # When using an exact executable, assume it is a reference build for the
   # purpose of outputting the perf results.
   results.PrintSummary(options.browser_executable and '_ref' or '')
 
   if len(results.page_failures):
     logging.warning('Failed pages: %s', '\n'.join(
         [failure['page'].url for failure in results.page_failures]))
 
   if len(results.skipped_pages):
     logging.warning('Skipped pages: %s', '\n'.join(
         [skipped['page'].url for skipped in results.skipped_pages]))
   return min(255, len(results.page_failures))