Issue 11428100: Add NULL check in SystemTray::ShowDetailedView.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11428100: Add NULL check in SystemTray::ShowDetailedView. (Closed)

Created:
8 years ago by kinaba

Modified:
8 years ago

Reviewers:
sadrul

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Add NULL check in SystemTray::ShowDetailedView. The pointer can be NULL when the detailed view creation failed (SystemTrayBubble::UpdateView => !bubble_view_->has_children() => Close). BUG=163518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170434

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -1 line)			Patch
	M	ash/system/tray/system_tray.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	ash/system/tray/system_tray_unittest.cc	View	1	2 chunks	+43 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

kinaba

On 2012/11/30 04:44:44, sadrul wrote: > Would you mind adding a test? Sounds good. Done.

8 years ago (2012-11-30 05:10:23 UTC) #3

commit-bot: I haz the power

8 years ago (2012-11-30 05:22:07 UTC) #5

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/kinaba@chromium.org/11428100/7001