Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Side by Side Diff: chrome/browser/resources/options/cookies_list.js

Issue 11428098: In chrome://settings/cookies dialog I extended hovering tooltip area for cookies which have been se… (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 cr.define('options', function() { 5 cr.define('options', function() {
6 /** @const */ var DeletableItemList = options.DeletableItemList; 6 /** @const */ var DeletableItemList = options.DeletableItemList;
7 /** @const */ var DeletableItem = options.DeletableItem; 7 /** @const */ var DeletableItem = options.DeletableItem;
8 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel; 8 /** @const */ var ArrayDataModel = cr.ui.ArrayDataModel;
9 /** @const */ var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel; 9 /** @const */ var ListSingleSelectionModel = cr.ui.ListSingleSelectionModel;
10 10
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 /** 81 /**
82 * Adds information about an app that protects this data item to the 82 * Adds information about an app that protects this data item to the
83 * @{code element}. 83 * @{code element}.
84 * @param {Element} element The DOM element the information should be 84 * @param {Element} element The DOM element the information should be
85 appended to. 85 appended to.
86 * @param {{id: string, name: string}} appInfo Information about an app. 86 * @param {{id: string, name: string}} appInfo Information about an app.
87 */ 87 */
88 function addAppInfo(element, appInfo) { 88 function addAppInfo(element, appInfo) {
89 var img = element.ownerDocument.createElement('img'); 89 var img = element.ownerDocument.createElement('img');
90 img.src = 'chrome://extension-icon/' + appInfo.id + '/16/1'; 90 img.src = 'chrome://extension-icon/' + appInfo.id + '/16/1';
91 img.title = loadTimeData.getString('label_protected_by_apps') + 91 element.title = loadTimeData.getString('label_protected_by_apps') +
92 ' ' + appInfo.name; 92 ' ' + appInfo.name;
battre 2012/12/01 01:56:00 nit: I think you should move this down after line
93 img.className = 'protecting-app'; 93 img.className = 'protecting-app';
94 element.appendChild(img); 94 element.appendChild(img);
95 } 95 }
96 96
97 var parentLookup = {}; 97 var parentLookup = {};
98 var lookupRequests = {}; 98 var lookupRequests = {};
99 99
100 /** 100 /**
101 * Creates a new list item for sites data. Note that these are created and 101 * Creates a new list item for sites data. Note that these are created and
102 * destroyed lazily as they scroll into and out of view, so they must be 102 * destroyed lazily as they scroll into and out of view, so they must be
(...skipping 814 matching lines...) Expand 10 before | Expand all | Expand 10 after
917 parent.clear(); 917 parent.clear();
918 this.addByParent_(parent, 0, children); 918 this.addByParent_(parent, 0, children);
919 parent.endBatchUpdates(); 919 parent.endBatchUpdates();
920 }, 920 },
921 }; 921 };
922 922
923 return { 923 return {
924 CookiesList: CookiesList 924 CookiesList: CookiesList
925 }; 925 };
926 }); 926 });
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698