Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6898)

Unified Diff: chromeos/network/onc/onc_validator.h

Issue 11428078: Rejecting networks/certificates individually from ONC during validation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@add_error_handling_to_validator
Patch Set: Addressed Steven's comment. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/network/onc/onc_mapper.h ('k') | chromeos/network/onc/onc_validator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/network/onc/onc_validator.h
diff --git a/chromeos/network/onc/onc_validator.h b/chromeos/network/onc/onc_validator.h
index 3410f3a9f4c6e05867685c90b2db55097ab61441..8c31461c09b98d68078db319f2d06aeda5a747c1 100644
--- a/chromeos/network/onc/onc_validator.h
+++ b/chromeos/network/onc/onc_validator.h
@@ -97,7 +97,7 @@ class CHROMEOS_EXPORT Validator : public Mapper {
// Dispatch to the right validation function according to
// |signature|. Iterates over all fields and recursively validates/repairs
// these. All valid fields are added to the result dictionary. Returns the
- // repaired dictionary. On error returns NULL.
+ // repaired dictionary. Only on error returns NULL.
virtual scoped_ptr<base::DictionaryValue> MapObject(
const OncValueSignature& signature,
const base::DictionaryValue& onc_object,
@@ -111,6 +111,13 @@ class CHROMEOS_EXPORT Validator : public Mapper {
bool* found_unknown_field,
bool* error) OVERRIDE;
+ // Ignores nested errors in NetworkConfigurations and Certificates, otherwise
+ // like |Mapper::MapArray|.
+ virtual scoped_ptr<base::ListValue> MapArray(
+ const OncValueSignature& array_signature,
+ const base::ListValue& onc_array,
+ bool* nested_error) OVERRIDE;
+
// Pushes/pops the index to |path_|, otherwise like |Mapper::MapEntry|.
virtual scoped_ptr<base::Value> MapEntry(
int index,
« no previous file with comments | « chromeos/network/onc/onc_mapper.h ('k') | chromeos/network/onc/onc_validator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698