Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: chromeos/test/data/network/invalid_settings_with_repairs.json

Issue 11428078: Rejecting networks/certificates individually from ONC during validation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@add_error_handling_to_validator
Patch Set: Rebased. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/test/data/network/invalid_settings_with_repairs.json
diff --git a/chromeos/test/data/network/invalid_settings_with_repairs.json b/chromeos/test/data/network/invalid_settings_with_repairs.json
index 34f521fa10be4f4aa5760d7b5aede00bbd403737..ec432425882c6e15e48023eca01d0dab9e8dd6aa 100644
--- a/chromeos/test/data/network/invalid_settings_with_repairs.json
+++ b/chromeos/test/data/network/invalid_settings_with_repairs.json
@@ -18,7 +18,7 @@
"Authentication": "None"
}
},
- "managed-network-unknown-type": {
+ "managed-network-unknown-value": {
"GUID": "guid",
"Type": "LTE",
"Name": "name",
@@ -26,6 +26,27 @@
"Authentication": "None"
}
},
+ "managed-network-value-out-of-range": {
+ "GUID": "guid",
+ "Type": "Ethernet",
+ "Name": "name",
+ "IPConfigs": [
+ { "Type": "IPv4",
+ "IPAddress": "127.0.0.1",
+ "RoutingPrefix": 123 }
+ ],
+ "Ethernet": {
+ "Authentication": "None"
+ }
+ },
+ "managed-network-wrong-type": {
+ "GUID": "guid",
+ "Type": "LTE",
+ "Name": "name",
+ "Ethernet": {
+ "Authentication": 123
+ }
+ },
"managed-network-unknown-recommended": {
"Recommended": ["abc"],
"GUID": "guid",
@@ -53,6 +74,7 @@
}
},
"network-repaired": {
+ "GUID": "guid",
"Type": "Ethernet",
"Name": "name",
"Ethernet": {
@@ -60,6 +82,7 @@
}
},
"network-unknown-fieldname": {
+ "GUID": "guid",
"abc": "def",
"Type": "Ethernet",
"Name": "name",
@@ -67,13 +90,35 @@
"Authentication": "None"
}
},
- "network-unknown-type": {
+ "network-unknown-value": {
+ "GUID": "guid",
"Type": "LTE",
"Name": "name",
"Ethernet": {
"Authentication": "None"
}
},
+ "network-value-out-of-range": {
+ "GUID": "guid",
+ "Type": "Ethernet",
+ "Name": "name",
+ "IPConfigs": [
+ { "Type": "IPv4",
+ "IPAddress": "127.0.0.1",
+ "RoutingPrefix": 123 }
+ ],
+ "Ethernet": {
+ "Authentication": "None"
+ }
+ },
+ "network-wrong-type": {
+ "GUID": "guid",
+ "Type": "LTE",
+ "Name": "name",
+ "Ethernet": {
+ "Authentication": 123
+ }
+ },
"network-missing-required": {
"Type": "Ethernet",
"Name": "name",
@@ -81,12 +126,44 @@
"Authentication": "None"
}
},
- "network-illegal-recommended": {
- "Recommended": [],
+ "network-with-illegal-recommended": {
+ "GUID": "guid",
+ "Recommended": ["Name"],
"Type": "Ethernet",
"Name": "name",
"Ethernet": {
"Authentication": "None"
}
},
+ "toplevel-repaired": {
+ "Type": "UnencryptedConfiguration",
+ "NetworkConfigurations":
+ [ { "GUID": "guid",
+ "Type": "Ethernet",
+ "Name": "eth0",
+ "Ethernet": {
+ "Authentication": "None"
+ }
+ }
+ ]
+ },
+ "toplevel-invalid-network": {
+ "Type": "UnencryptedConfiguration",
+ "NetworkConfigurations":
+ [ { "GUID": "guid",
+ "Type": "unknown",
+ "Name": "unknown name",
+ "Ethernet": {
+ "Authentication": "None"
+ }
+ },
+ { "GUID": "guid",
+ "Type": "Ethernet",
+ "Name": "eth0",
+ "Ethernet": {
+ "Authentication": "None"
+ }
+ }
+ ]
+ },
}

Powered by Google App Engine
This is Rietveld 408576698