Merge the Merlin heap tracing to top-of-trunk.

runtime/vm/heap.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/heap.h"
 
 #include "platform/assert.h"
 #include "platform/utils.h"
 #include "vm/compiler_stats.h"
 #include "vm/flags.h"
 #include "vm/heap_profiler.h"
+#include "vm/heap_trace.h"
 #include "vm/isolate.h"
 #include "vm/object.h"
 #include "vm/object_set.h"
 #include "vm/os.h"
 #include "vm/pages.h"
+#include "vm/raw_object.h"
 #include "vm/scavenger.h"
 #include "vm/stack_frame.h"
 #include "vm/verifier.h"
 #include "vm/virtual_memory.h"
 
 namespace dart {
 
 DEFINE_FLAG(bool, verbose_gc, false, "Enables verbose GC.");
 DEFINE_FLAG(bool, verify_before_gc, false,
             "Enables heap verification before GC.");
 DEFINE_FLAG(bool, verify_after_gc, false,
             "Enables heap verification after GC.");
 DEFINE_FLAG(bool, gc_at_alloc, false, "GC at every allocation.");
 DEFINE_FLAG(int, new_gen_heap_size, 32, "new gen heap size in MB,"
             "e.g: --new_gen_heap_size=64 allocates a 64MB new gen heap");
 DEFINE_FLAG(int, old_gen_heap_size, Heap::kHeapSizeInMB,
             "old gen heap size in MB,"
             "e.g: --old_gen_heap_size=1024 allocates a 1024MB old gen heap");
 
 Heap::Heap() : read_only_(false) {
   new_space_ = new Scavenger(this,
                              (FLAG_new_gen_heap_size * MB),
                              kNewObjectAlignmentOffset);
   old_space_ = new PageSpace(this, (FLAG_old_gen_heap_size * MB));
+  heap_trace_ = HeapTrace::is_enabled() ? new HeapTrace : NULL;

[siva, 2012/12/05 16:06:40]

new HeapTrace() ?

[cshapiro, 2012/12/08 03:23:08]

Parenthesis are not required.  We do not put parenthesis around every 0 argument
construction.  Is there a reason to start now.

 }
 
 
 Heap::~Heap() {
   delete new_space_;
   delete old_space_;
 }
 
 
 uword Heap::AllocateNew(intptr_t size) {
   ASSERT(Isolate::Current()->no_gc_scope_depth() == 0);
   uword addr = new_space_->TryAllocate(size);
-  if (addr != 0) {
-    return addr;
+  if (addr == 0) {
+    CollectGarbage(kNew);
+    addr = new_space_->TryAllocate(size);
+    if (addr == 0) {
+      return AllocateOld(size, HeapPage::kData);
+    }
   }
-  CollectGarbage(kNew);
-  addr = new_space_->TryAllocate(size);
-  if (addr != 0) {
-    return addr;
+  if (HeapTrace::is_enabled()) {
+    heap_trace_->TraceAllocation(addr, size);
   }
-  return AllocateOld(size, HeapPage::kData);
+  return addr;
 }
 
 
 uword Heap::AllocateOld(intptr_t size, HeapPage::PageType type) {
   ASSERT(Isolate::Current()->no_gc_scope_depth() == 0);
   uword addr = old_space_->TryAllocate(size, type);
   if (addr == 0) {
     CollectAllGarbage();
     addr = old_space_->TryAllocate(size, type, PageSpace::kForceGrowth);
     if (addr == 0) {
       OS::PrintErr("Exhausted heap space, trying to allocate %"Pd" bytes.\n",
                    size);
+      return 0;
     }
   }
+  if (HeapTrace::is_enabled()) {
+    heap_trace_->TraceAllocation(addr, size);
+  }
   return addr;
 }
 
 
 bool Heap::Contains(uword addr) const {
   return new_space_->Contains(addr) ||
       old_space_->Contains(addr);
 }
 
 
@@ skipping 175 matching lines @@
 
 
 void Heap::PrintSizes() const {
   OS::PrintErr("New space (%"Pd"k of %"Pd"k) "
                "Old space (%"Pd"k of %"Pd"k)\n",
                (new_space_->in_use() / KB), (new_space_->capacity() / KB),
                (old_space_->in_use() / KB), (old_space_->capacity() / KB));
 }
 
 
-void Heap::Profile(Dart_HeapProfileWriteCallback callback, void* stream) const {
+void Heap::Profile(Dart_FileWriteCallback callback, void* stream) const {
   HeapProfiler profiler(callback, stream);
 
   // Dump the root set.
   HeapProfilerRootVisitor root_visitor(&profiler);
   Isolate* isolate = Isolate::Current();
   Isolate* vm_isolate = Dart::vm_isolate();
   isolate->VisitObjectPointers(&root_visitor, false,
                                StackFrameIterator::kDontValidateFrames);
   HeapProfilerWeakRootVisitor weak_root_visitor(&root_visitor);
   isolate->VisitWeakPersistentHandles(&weak_root_visitor, true);
@@ skipping 57 matching lines @@
   isolate()->IncrementNoGCScopeDepth();
 }
 
 
 NoGCScope::~NoGCScope() {
   isolate()->DecrementNoGCScopeDepth();
 }
 #endif  // defined(DEBUG)
 
 }  // namespace dart