Add a flag to LaunchSelLdr to skip grabbing a routing_id.

chrome/browser/nacl_host/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/nacl_host/nacl_process_host.h"
 
 #include <string>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 722 matching lines @@
   }
 #endif
 
   process_->Send(new NaClProcessMsg_Start(params));
 
   internal_->sockets_for_sel_ldr.clear();
   return true;
 }
 
 bool NaClProcessHost::SendStart() {
-  if (!enable_ipc_proxy_) {
+  // If render_view_id == 0, reply to the Renderer now, and skip creation
+  // of the PPAPI IPC proxy channel in OnPpapiChannelCreated.
+  if (!enable_ipc_proxy_ || !render_view_id_) {

[bbudge, 2012/11/30 00:49:46]

If you really don't need any IPC stuff, it would be simpler to check
render_view_id_ in the NaClProcessHost ctor and if it's 0, set enable_ipc_proxy_
to false.

[jvoung (off chromium), 2012/11/30 01:34:09]

Ah ok.  Done.

     if (!ReplyToRenderer(IPC::ChannelHandle()))
       return false;
   }
   return StartNaClExecution();
 }
 
 // This method is called when NaClProcessHostMsg_PpapiChannelCreated is
 // received or PpapiHostMsg_ChannelCreated is forwarded by our plugin
 // listener.
 void NaClProcessHost::OnPpapiChannelCreated(
     const IPC::ChannelHandle& channel_handle) {
   DCHECK(enable_ipc_proxy_);
   // If the proxy channel is null, this must be the initial NaCl-Browser IPC
   // channel.
   if (!ipc_proxy_channel_.get()) {
-    ipc_proxy_channel_.reset(
-        new IPC::ChannelProxy(channel_handle,
-                              IPC::Channel::MODE_CLIENT,
-                              &ipc_plugin_listener_,
-                              base::MessageLoopProxy::current()));
-    // Create the browser ppapi host and enable PPAPI message dispatching to the
-    // browser process.
-    content::BrowserPpapiHost::CreateExternalPluginProcess(
-        process_.get(),  // sender
-        permissions_,
-        process_->GetData().handle,
-        ipc_proxy_channel_.get(),
-        chrome_render_message_filter_->GetHostResolver(),
-        chrome_render_message_filter_->render_process_id(),
-        render_view_id_);
-    // Send a message to create the NaCl-Renderer channel. The handle is just
-    // a place holder.
-    ipc_proxy_channel_->Send(
-        new PpapiMsg_CreateNaClChannel(
-            chrome_render_message_filter_->render_process_id(),
-            permissions_,
-            chrome_render_message_filter_->off_the_record(),
-            SerializedHandle(SerializedHandle::CHANNEL_HANDLE,
-                             IPC::InvalidPlatformFileForTransit())));
+    // If render_view_id_ == 0, then we are launching a nexe that does not need
+    // the PPAPI IPC proxy.  In that case, we have already ReplyToRenderer'ed
+    // in SendStart, so there is nothing to do.
+    // Otherwise, we need the ipc_proxy_channel_.
+    if (render_view_id_) {
+      ipc_proxy_channel_.reset(
+          new IPC::ChannelProxy(channel_handle,
+                                IPC::Channel::MODE_CLIENT,
+                                &ipc_plugin_listener_,
+                                base::MessageLoopProxy::current()));
+      // Create the browser ppapi host and enable PPAPI message dispatching
+      // to the browser process.
+      content::BrowserPpapiHost::CreateExternalPluginProcess(
+          process_.get(),  // sender
+          permissions_,
+          process_->GetData().handle,
+          ipc_proxy_channel_.get(),
+          chrome_render_message_filter_->GetHostResolver(),
+          chrome_render_message_filter_->render_process_id(),
+          render_view_id_);
+      // Send a message to create the NaCl-Renderer channel. The handle is just
+      // a place holder.
+      ipc_proxy_channel_->Send(
+          new PpapiMsg_CreateNaClChannel(
+              chrome_render_message_filter_->render_process_id(),
+              permissions_,
+              chrome_render_message_filter_->off_the_record(),
+              SerializedHandle(SerializedHandle::CHANNEL_HANDLE,
+                               IPC::InvalidPlatformFileForTransit())));
+    }
   } else if (reply_msg_) {
     // Otherwise, this must be a renderer channel.
     ReplyToRenderer(channel_handle);
   } else {
     // Attempt to open more than 1 renderer channel is not supported.
     // Shut down the NaCl process.
     process_->GetHost()->ForceShutdown();
   }
 }
 
@@ skipping 106 matching lines @@
   } else {
     NaClStartDebugExceptionHandlerThread(
         process_handle.Take(), info,
         base::MessageLoopProxy::current(),
         base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
                    weak_factory_.GetWeakPtr()));
     return true;
   }
 }
 #endif