Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java

Issue 11428055: Issue 6964. Optionally don't warn in Editor when class with noSuchMethod() has unimplemented member… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
diff --git a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
index c6fc65acb3a2d7214ed7608e51e655fb504fff79..c766ad0a431cf2d28774dc2bc8a4f2219557f656 100644
--- a/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
+++ b/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
@@ -1606,7 +1606,8 @@ public class TypeAnalyzer implements DartCompilationPhase {
// remember unimplemented members
{
List<Element> unimplementedMembers = findUnimplementedMembers(element);
- if (!node.getModifiers().isAbstract() && !unimplementedMembers.isEmpty()) {
+ if (!node.getModifiers().isAbstract() && !unimplementedMembers.isEmpty() &&
+ (reportNoMemberWhenHasInterceptor || !Elements.handlesNoSuchMethod(type))) {
StringBuilder sb = getUnimplementedMembersMessage(element, unimplementedMembers);
onError(node.getName(), TypeErrorCode.CONTRETE_CLASS_WITH_UNIMPLEMENTED_MEMBERS,
node.getName(), sb.toString());
« no previous file with comments | « no previous file | compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698