Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2517)

Unified Diff: android_webview/browser/net/input_stream_reader_unittest.cc

Issue 11428052: [android_webview] Fix use after free in intercepted requests. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/net/input_stream_reader_unittest.cc
diff --git a/android_webview/browser/net/input_stream_reader_unittest.cc b/android_webview/browser/net/input_stream_reader_unittest.cc
index a218d788f70cf02b784f92276a092045dcf56093..7d6a52ee58878b8186f7056d72397092f51ea341 100644
--- a/android_webview/browser/net/input_stream_reader_unittest.cc
+++ b/android_webview/browser/net/input_stream_reader_unittest.cc
@@ -40,22 +40,22 @@ class MockInputStream : public InputStream {
class InputStreamReaderTest : public Test {
public:
InputStreamReaderTest()
- : input_stream_reader_(new InputStreamReader(&input_stream_)) {
+ : input_stream_reader_(&input_stream_) {
}
protected:
int SeekRange(int first_byte, int last_byte) {
net::HttpByteRange byte_range;
byte_range.set_first_byte_position(first_byte);
byte_range.set_last_byte_position(last_byte);
- return input_stream_reader_->Seek(byte_range);
+ return input_stream_reader_.Seek(byte_range);
}
int ReadRawData(scoped_refptr<net::IOBuffer> buffer, int bytesToRead) {
- return input_stream_reader_->ReadRawData(buffer.get(), bytesToRead);
+ return input_stream_reader_.ReadRawData(buffer.get(), bytesToRead);
}
MockInputStream input_stream_;
- scoped_refptr<InputStreamReader> input_stream_reader_;
+ InputStreamReader input_stream_reader_;
};
TEST_F(InputStreamReaderTest, BytesAvailableFailurePropagationOnSeek) {

Powered by Google App Engine
This is Rietveld 408576698