Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6737)

Unified Diff: chrome/browser/google_apis/gdata_wapi_parser.h

Issue 11428046: Add changestamp field to google_apis::DocumentEntry (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: +comment Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/google_apis/gdata_wapi_parser.h
diff --git a/chrome/browser/google_apis/gdata_wapi_parser.h b/chrome/browser/google_apis/gdata_wapi_parser.h
index 684b219b70f6230eb552a7b39ddcc86e2655d765..2c5babc42b69e0a561cfebe374a589b31513cd23 100644
--- a/chrome/browser/google_apis/gdata_wapi_parser.h
+++ b/chrome/browser/google_apis/gdata_wapi_parser.h
@@ -386,6 +386,10 @@ class DocumentEntry : public FeedEntry {
// their value nodes.
satorux1 2012/12/03 05:59:57 Please also fix this comment too.
tzik 2012/12/03 06:16:34 Done.
static bool HasFieldPresent(const base::Value* value, bool* result);
+ // Helper function for parsing changestamp.
satorux1 2012/12/03 05:59:57 The function comment looks not good. Please revise
tzik 2012/12/03 06:16:34 Done.
+ static bool OptionalChangestamp(const base::StringPiece& value,
satorux1 2012/12/03 05:59:57 Function names should usually start with a verb.
tzik 2012/12/03 06:16:34 Done.
+ int64* result);
+
// Returns true if |file| has one of the hosted document extensions.
static bool HasHostedDocumentExtension(const FilePath& file);
@@ -434,6 +438,9 @@ class DocumentEntry : public FeedEntry {
// True if the file or directory is deleted (applicable to change feeds only).
bool deleted() const { return deleted_ || removed_; }
+ // Changestamp (exists only for change query results).
+ int64 changestamp() const { return changestamp_; }
+
// Text version of document entry kind. Returns an empty string for
// unknown entry kind.
std::string GetEntryKindText() const;
@@ -517,6 +524,7 @@ class DocumentEntry : public FeedEntry {
int64 file_size_;
bool deleted_;
bool removed_;
+ int64 changestamp_;
DISALLOW_COPY_AND_ASSIGN(DocumentEntry);
};
« no previous file with comments | « no previous file | chrome/browser/google_apis/gdata_wapi_parser.cc » ('j') | chrome/browser/google_apis/gdata_wapi_parser.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698