Add changestamp field to google_apis::DocumentEntry

chrome/browser/google_apis/gdata_wapi_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_PARSER_H_
 #define CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_PARSER_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 364 matching lines @@
       const ChangeResource& change);
 
   // Returns name of entry node.
   static std::string GetEntryNodeName();
 
   // Registers the mapping between JSON field names and the members in
   // this class.
   static void RegisterJSONConverter(
       base::JSONValueConverter<DocumentEntry>* converter);
 
   // Helper function for parsing bool fields based on presence of

[satorux1, 2012/12/03 06:38:11]

See below. Please fix the function comment while you are at it.

[tzik, 2012/12/03 07:49:11]

Done.

   // their value nodes.
+  // Returns true even when |value| is NULL.
   static bool HasFieldPresent(const base::Value* value, bool* result);
 
+  // Helper function for parsing changestamp. If the field does not exists,

[satorux1, 2012/12/03 06:38:11]

Rewrite "Helper function for parsing changestamp" part. Function comments should
usually start with a verb.

Cannot we drop "Optional" from the function name?

[tzik, 2012/12/03 07:49:11]

Done.

+  // this function sets the changestamp to 0.
+  // Returns true even when |value| is NULL.
+  static bool ParseOptionalChangestamp(const base::StringPiece& value,
+                                       int64* result);
+
   // Returns true if |file| has one of the hosted document extensions.
   static bool HasHostedDocumentExtension(const FilePath& file);
 
   // Document entry resource id.
   const std::string& resource_id() const { return resource_id_; }
 
   // Document entry id.
   const std::string& id() const { return id_; }
 
   // Document entry kind.
@@ skipping 28 matching lines @@
 
   // Document feed file content MD5 (exists only for kinds FILE and PDF).
   const std::string& file_md5() const { return file_md5_; }
 
   // Document feed file size (exists only for kinds FILE and PDF).
   int64 file_size() const { return file_size_; }
 
   // True if the file or directory is deleted (applicable to change feeds only).
   bool deleted() const { return deleted_ || removed_; }
 
+  // Changestamp (exists only for change query results).

[satorux1, 2012/12/03 06:38:11]

If it does not exist, what's the value of this? Please describe.

[tzik, 2012/12/03 07:49:11]

Done.

+  int64 changestamp() const { return changestamp_; }
+
   // Text version of document entry kind. Returns an empty string for
   // unknown entry kind.
   std::string GetEntryKindText() const;
 
   // Returns preferred file extension for hosted documents. If entry is not
   // a hosted document, this call returns an empty string.
   std::string GetHostedDocumentExtension() const;
 
   // True if document entry is remotely hosted.
   bool is_hosted_document() const {
@@ skipping 63 matching lines @@
   std::vector<string16> labels_;
   Content content_;
   ScopedVector<FeedLink> feed_links_;
   // Optional fields for files only.
   string16 filename_;
   string16 suggested_filename_;
   std::string file_md5_;
   int64 file_size_;
   bool deleted_;
   bool removed_;
+  int64 changestamp_;
 
   DISALLOW_COPY_AND_ASSIGN(DocumentEntry);
 };
 
 // Document feed represents a list of entries. The feed is paginated and
 // the rest of the feed can be fetched by retrieving the remaining parts of the
 // feed from URLs provided by GetNextFeedURL() method.
 class DocumentFeed : public FeedEntry {
  public:
   virtual ~DocumentFeed();
@@ skipping 197 matching lines @@
   int64 largest_changestamp_;
   ScopedVector<InstalledApp> installed_apps_;
 
   DISALLOW_COPY_AND_ASSIGN(AccountMetadataFeed);
 };
 
 
 }  // namespace google_apis
 
 #endif  // CHROME_BROWSER_GOOGLE_APIS_GDATA_WAPI_PARSER_H_