Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Unified Diff: sync/protocol/proto_value_conversions_unittest.cc

Issue 11428004: Sync the bookmark's icon URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sync/protocol/proto_value_conversions_unittest.cc
diff --git a/sync/protocol/proto_value_conversions_unittest.cc b/sync/protocol/proto_value_conversions_unittest.cc
index e87888c2c34d37ff7905358505a71cac15c9c088..642037c631be7369fbbe2de2c9154daad7447c5e 100644
--- a/sync/protocol/proto_value_conversions_unittest.cc
+++ b/sync/protocol/proto_value_conversions_unittest.cc
@@ -124,13 +124,18 @@ TEST_F(ProtoValueConversionsTest, BookmarkSpecificsToValue) {
TEST_F(ProtoValueConversionsTest, BookmarkSpecificsData) {
const base::Time creation_time(base::Time::Now());
+ const std::string icon_url = "http://www.google.com/favicon.ico";
sync_pb::BookmarkSpecifics specifics;
specifics.set_creation_time_us(creation_time.ToInternalValue());
+ specifics.set_icon_url(icon_url);
scoped_ptr<DictionaryValue> value(BookmarkSpecificsToValue(specifics));
EXPECT_FALSE(value->empty());
std::string encoded_time;
EXPECT_TRUE(value->GetString("creation_time_us", &encoded_time));
EXPECT_EQ(base::Int64ToString(creation_time.ToInternalValue()), encoded_time);
+ std::string encoded_icon_url;
+ EXPECT_TRUE(value->GetString("icon_url", &encoded_icon_url));
+ EXPECT_EQ(icon_url, encoded_icon_url);
}
TEST_F(ProtoValueConversionsTest, DeviceInfoSpecificsToValue) {

Powered by Google App Engine
This is Rietveld 408576698