chrome/browser/sync/glue/bookmark_change_processor.h - Issue 11428004: Sync the bookmark's icon URL

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/glue/bookmark_change_processor.h

Issue 11428004: Sync the bookmark's icon URL (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebased Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/sync/glue/bookmark_change_processor.h

diff --git a/chrome/browser/sync/glue/bookmark_change_processor.h b/chrome/browser/sync/glue/bookmark_change_processor.h

index 749e121f0d4b9f0d31998810a6425d34b10b17c3..58e03bedc77c989db3c7c2c255d2ee78bc6dad5e 100644

--- a/chrome/browser/sync/glue/bookmark_change_processor.h

+++ b/chrome/browser/sync/glue/bookmark_change_processor.h

@@ -93,12 +93,13 @@ class BookmarkChangeProcessor : public BookmarkModelObserver,

const BookmarkNode* bookmark_node,

BookmarkModel* model);

- // Applies the favicon 1x |bitmap_data| to |bookmark_node|.

+ // Applies the 1x favicon |bitmap_data| and |icon_url| to |bookmark_node|.

// |profile| is the profile that contains the HistoryService and BookmarkModel

// for the bookmark in question.

static void ApplyBookmarkFavicon(

const BookmarkNode* bookmark_node,

Profile* profile,

+ const GURL& icon_url,

const scoped_refptr<base::RefCountedMemory>& bitmap_data);

// Sets the favicon of the given sync node from the given bookmark node.