Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 1142733003: win: Disable oilpan plugin when doing asan builds. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 7 months ago
Reviewers:
Reid Kleckner, hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Disable oilpan plugin when doing asan builds. The oilpan plugin requires trunk clang on Windows, but the asan lkgr bot uses a pinned, slightly older clang and it times out when using head clang. Disable the plugin on asan until we have resolved this. BUG=489123, 489123 R=hans@chromium.org, rnk@chromium.org Committed: https://crrev.com/1bdb383d4338a68b88bcdb96852592c933544595 Cr-Commit-Position: refs/heads/master@{#330432}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M build/common.gypi View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Nico
5 years, 7 months ago (2015-05-18 20:06:44 UTC) #2
hans
lgtm Maybe update the title to reflect that this is just asan on windows.
5 years, 7 months ago (2015-05-18 20:12:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142733003/1
5 years, 7 months ago (2015-05-18 20:17:26 UTC) #6
Reid Kleckner
lgtm Thanks!
5 years, 7 months ago (2015-05-18 20:18:29 UTC) #7
Nico
Committed patchset #1 (id:1) manually as 1bdb383d4338a68b88bcdb96852592c933544595 (presubmit successful).
5 years, 7 months ago (2015-05-18 21:46:56 UTC) #8
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 22:44:11 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bdb383d4338a68b88bcdb96852592c933544595
Cr-Commit-Position: refs/heads/master@{#330432}

Powered by Google App Engine
This is Rietveld 408576698