Issue 1142713008: Allow using c/b/ui/passwords/password_bubble_experiment.* on iOS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1142713008: Allow using c/b/ui/passwords/password_bubble_experiment.* on iOS (Closed)

Created:
5 years, 7 months ago by vabr (Chromium)

Modified:
5 years, 7 months ago

Reviewers:
dconnelly

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Allow using c/b/ui/passwords/password_bubble_experiment.* on iOS R=dconnelly@chromium.org BUG=486739 Committed: https://crrev.com/80439f48e3d54a2ccd4557049802c8add32a5f82 Cr-Commit-Position: refs/heads/master@{#330511}

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	chrome/chrome_browser_ui.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

vabr (Chromium)

Hi Daniel, PTAL. I understand that landing this is a pre-requisite to adding the password_bubble_experiment.h ...

5 years, 7 months ago (2015-05-19 11:24:40 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142713008/1

5 years, 7 months ago (2015-05-19 12:03:50 UTC) #4

commit-bot: I haz the power

5 years, 7 months ago (2015-05-19 13:12:05 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/80439f48e3d54a2ccd4557049802c8add32a5f82
Cr-Commit-Position: refs/heads/master@{#330511}