Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Side by Side Diff: src/x87/debug-x87.cc

Issue 1142713007: X87: Now that vector ics are established for load, keyed load and call ics, let's remove dead code … (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/x87/code-stubs-x87.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #if V8_TARGET_ARCH_X87 7 #if V8_TARGET_ARCH_X87
8 8
9 #include "src/codegen.h" 9 #include "src/codegen.h"
10 #include "src/debug.h" 10 #include "src/debug.h"
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
175 // ----------------------------------- 175 // -----------------------------------
176 Generate_DebugBreakCallHelper(masm, edx.bit() | edi.bit(), 176 Generate_DebugBreakCallHelper(masm, edx.bit() | edi.bit(),
177 0, false); 177 0, false);
178 } 178 }
179 179
180 180
181 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) { 181 void DebugCodegen::GenerateLoadICDebugBreak(MacroAssembler* masm) {
182 // Register state for IC load call (from ic-x87.cc). 182 // Register state for IC load call (from ic-x87.cc).
183 Register receiver = LoadDescriptor::ReceiverRegister(); 183 Register receiver = LoadDescriptor::ReceiverRegister();
184 Register name = LoadDescriptor::NameRegister(); 184 Register name = LoadDescriptor::NameRegister();
185 RegList regs = receiver.bit() | name.bit(); 185 RegList regs = receiver.bit() | name.bit() |
186 if (FLAG_vector_ics) { 186 VectorLoadICTrampolineDescriptor::SlotRegister().bit();
187 regs |= VectorLoadICTrampolineDescriptor::SlotRegister().bit();
188 }
189 Generate_DebugBreakCallHelper(masm, regs, 0, false); 187 Generate_DebugBreakCallHelper(masm, regs, 0, false);
190 } 188 }
191 189
192 190
193 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) { 191 void DebugCodegen::GenerateStoreICDebugBreak(MacroAssembler* masm) {
194 // Register state for IC store call (from ic-x87.cc). 192 // Register state for IC store call (from ic-x87.cc).
195 Register receiver = StoreDescriptor::ReceiverRegister(); 193 Register receiver = StoreDescriptor::ReceiverRegister();
196 Register name = StoreDescriptor::NameRegister(); 194 Register name = StoreDescriptor::NameRegister();
197 Register value = StoreDescriptor::ValueRegister(); 195 Register value = StoreDescriptor::ValueRegister();
198 Generate_DebugBreakCallHelper( 196 Generate_DebugBreakCallHelper(
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 } 319 }
322 320
323 321
324 const bool LiveEdit::kFrameDropperSupported = true; 322 const bool LiveEdit::kFrameDropperSupported = true;
325 323
326 #undef __ 324 #undef __
327 325
328 } } // namespace v8::internal 326 } } // namespace v8::internal
329 327
330 #endif // V8_TARGET_ARCH_X87 328 #endif // V8_TARGET_ARCH_X87
OLDNEW
« no previous file with comments | « src/x87/code-stubs-x87.cc ('k') | src/x87/full-codegen-x87.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698