Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 1142713007: X87: Now that vector ics are established for load, keyed load and call ics, let's remove dead code … (Closed)

Created:
5 years, 7 months ago by chunyang.dai
Modified:
5 years, 7 months ago
Reviewers:
Weiliang
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

X87: Now that vector ics are established for load, keyed load and call ics, let's remove dead code behind the flag. port 323ced9e272e234d19db13d407b5bb9da266681d (r28422). original commit message: BUG= Committed: https://crrev.com/528aa288bfa494f46356c0beb6ec9cb37daf8675 Cr-Commit-Position: refs/heads/master@{#28467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -177 lines) Patch
M src/ic/x87/handler-compiler-x87.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/ic/x87/ic-x87.cc View 4 chunks +23 lines, -36 lines 0 comments Download
M src/x87/code-stubs-x87.cc View 4 chunks +12 lines, -18 lines 0 comments Download
M src/x87/debug-x87.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/x87/full-codegen-x87.cc View 10 chunks +24 lines, -52 lines 0 comments Download
M src/x87/lithium-codegen-x87.cc View 4 chunks +2 lines, -28 lines 0 comments Download
M src/x87/lithium-x87.h View 2 chunks +0 lines, -21 lines 0 comments Download
M src/x87/lithium-x87.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
chunyang.dai
PTAL
5 years, 7 months ago (2015-05-19 09:20:17 UTC) #2
Weiliang
lgtm
5 years, 7 months ago (2015-05-19 09:33:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142713007/1
5 years, 7 months ago (2015-05-19 09:33:42 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-19 09:56:47 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 09:56:58 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/528aa288bfa494f46356c0beb6ec9cb37daf8675
Cr-Commit-Position: refs/heads/master@{#28467}

Powered by Google App Engine
This is Rietveld 408576698