core/src/fpdftext/fpdf_text_int.cpp - Issue 1142713005: Remove FX_Alloc() null checks now that it can't return NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdftext/fpdf_text_int.cpp

Issue 1142713005: Remove FX_Alloc() null checks now that it can't return NULL. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Fix missing FX_Alloc2D, check overflow on add, remove unused enum. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fpdftext/fpdf_text_int.cpp

diff --git a/core/src/fpdftext/fpdf_text_int.cpp b/core/src/fpdftext/fpdf_text_int.cpp

index 882b22ceecd282e94d8d045ad0d5ab0bfb14f277..69d0bc574f9b74fde506713d5ed70a38806a0b3d 100644

--- a/core/src/fpdftext/fpdf_text_int.cpp

+++ b/core/src/fpdftext/fpdf_text_int.cpp

@@ -1164,9 +1164,6 @@ void CPDF_TextPage::AddCharInfoByLRDirection(CFX_WideString& str, int i)

FX_STRSIZE nCount = FX_Unicode_GetNormalization(wChar, pDst);

if (nCount >= 1) {

pDst = FX_Alloc(FX_WCHAR, nCount);

- if (!pDst) {

- return;

- }

FX_Unicode_GetNormalization(wChar, pDst);

for (int nIndex = 0; nIndex < nCount; nIndex++) {

PAGECHAR_INFO Info2 = Info;

@@ -1199,9 +1196,6 @@ void CPDF_TextPage::AddCharInfoByRLDirection(CFX_WideString& str, int i)