core/src/fxcrt/fxcrt_platforms.cpp - Issue 1142713005: Remove FX_Alloc() null checks now that it can't return NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/fxcrt_platforms.cpp

Issue 1142713005: Remove FX_Alloc() null checks now that it can't return NULL. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxcrt/fxcrt_platforms.cpp

diff --git a/core/src/fxcrt/fxcrt_platforms.cpp b/core/src/fxcrt/fxcrt_platforms.cpp

index d9b99624d37485cc750436a24355bdb451092010..942d6a3c026c55cd3ecbd9d065e56f982004c970 100644

--- a/core/src/fxcrt/fxcrt_platforms.cpp

+++ b/core/src/fxcrt/fxcrt_platforms.cpp

@@ -169,9 +169,6 @@ FX_BOOL FX_File_Copy(FX_BSTR fileNameSrc, FX_BSTR fileNameDst)

}

FX_FILESIZE num = 0;

FX_LPBYTE pBuffer = FX_Alloc(FX_BYTE, 32768);

- if (!pBuffer) {

- return FALSE;

- }

while (num = src.Read(pBuffer, 32768)) {

if (dst.Write(pBuffer, num) != num) {

break;

« core/src/fxcodec/codec/fx_codec_jbig.cpp ('K') | « core/src/fxcrt/fx_extension.cpp ('k') | core/src/fxcrt/fxcrt_posix.cpp » ('j') | core/src/fxge/ge/fx_ge_path.cpp » ('J')