Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 1142713004: fixes #184, type literals now use emitTypeName (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

fixes #184, type literals now use emitTypeName this fixes `dart.dynamic` as well as other cases covered by emitTypeName R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/2ab50a737a02eff1d2a98d91ee5925d987e06977

Patch Set 1 #

Total comments: 1

Patch Set 2 : fix dynamic #

Total comments: 2

Patch Set 3 : another case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -3 lines) Patch
M lib/src/codegen/js_codegen.dart View 1 1 chunk +7 lines, -0 lines 0 comments Download
M lib/src/utils.dart View 1 1 chunk +6 lines, -3 lines 0 comments Download
M test/codegen/expect/misc.js View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M test/codegen/misc.dart View 1 2 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
TIL, `dynamic` is its own strange thing in the Element model too. https://codereview.chromium.org/1142713004/diff/1/test/codegen/expect/misc.js File test/codegen/expect/misc.js ...
5 years, 7 months ago (2015-05-18 20:02:07 UTC) #2
vsm
lgtm https://codereview.chromium.org/1142713004/diff/20001/test/codegen/misc.dart File test/codegen/misc.dart (right): https://codereview.chromium.org/1142713004/diff/20001/test/codegen/misc.dart#newcode22 test/codegen/misc.dart:22: print(x == dynamic); If you had plain "Generic" ...
5 years, 7 months ago (2015-05-18 20:27:57 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1142713004/diff/20001/test/codegen/misc.dart File test/codegen/misc.dart (right): https://codereview.chromium.org/1142713004/diff/20001/test/codegen/misc.dart#newcode22 test/codegen/misc.dart:22: print(x == dynamic); On 2015/05/18 20:27:56, vsm wrote: > ...
5 years, 7 months ago (2015-05-18 20:41:14 UTC) #4
Jennifer Messerly
5 years, 7 months ago (2015-05-18 20:41:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
2ab50a737a02eff1d2a98d91ee5925d987e06977 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698