chrome/browser/extensions/api/passwords_private/passwords_private_api.h - Issue 1142693003: Implement the chrome.passwordsPrivate API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/passwords_private/passwords_private_api.h

Issue 1142693003: Implement the chrome.passwordsPrivate API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changed plaintext password retrieval to an event. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/password_ui_view_android.cc ('k') | chrome/browser/extensions/api/passwords_private/passwords_private_api.cc » ('j') | chrome/browser/extensions/api/passwords_private/passwords_private_delegate_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/passwords_private/passwords_private_api.h

diff --git a/chrome/browser/extensions/api/passwords_private/passwords_private_api.h b/chrome/browser/extensions/api/passwords_private/passwords_private_api.h

index 4cef1917f65877cd7aac77e2b9afeac96a7b7e94..6fdf3a2d30bc81d4055f8baf9c59a2a1d6f98ecb 100644

--- a/chrome/browser/extensions/api/passwords_private/passwords_private_api.h

+++ b/chrome/browser/extensions/api/passwords_private/passwords_private_api.h

@@ -8,6 +8,8 @@

#include <string>

#include "base/macros.h"

+#include "chrome/browser/extensions/api/passwords_private/passwords_private_delegate.h"

+#include "chrome/browser/ui/passwords/password_manager_presenter.h"

#include "extensions/browser/extension_function.h"

namespace extensions {

@@ -67,7 +69,7 @@ class PasswordsPrivateGetPlaintextPasswordFunction :

public UIThreadExtensionFunction {

public:

PasswordsPrivateGetPlaintextPasswordFunction() {}

- DECLARE_EXTENSION_FUNCTION("passwordsPrivate.GetPlaintextPassword",

+ DECLARE_EXTENSION_FUNCTION("passwordsPrivate.getPlaintextPassword",

PASSWORDSPRIVATE_GETPLAINTEXTPASSWORD);

protected: