Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3157)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/passwords/password_ui_view.h

Issue 1142693003: Implement the chrome.passwordsPrivate API. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add password_ui_view_android.h. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/extensions/api/passwords_private/passwords_private_api.h ('K') | « chrome/browser/ui/passwords/password_manager_presenter.cc ('k') | chrome/browser/ui/webui/options/password_manager_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/passwords/password_ui_view.h
diff --git a/chrome/browser/ui/passwords/password_ui_view.h b/chrome/browser/ui/passwords/password_ui_view.h
index 042022015d7d2b67b7d62c0e5273ac70dab03d2f..d17ce409e4058ad567366b8f9846b814ce4ef27b 100644
--- a/chrome/browser/ui/passwords/password_ui_view.h
+++ b/chrome/browser/ui/passwords/password_ui_view.h
@@ -24,10 +24,16 @@ class PasswordUIView {
// Returns the profile associated with the currently active profile.
virtual Profile* GetProfile() = 0;
- // Reveals the password for the saved password entry at |index| in the UI.
+ // Reveals the password for the saved password entry with origin URL
+ // |origin_url| and username |username| at index |index| in the UI.
// |index| the index of the saved password entry.
vabr (Chromium) 2015/05/22 09:00:25 nit: This comment line and some below seem to dupl
Kyle Horimoto 2015/05/22 17:52:53 Done.
+ // |origin_url| the URL of the saved password entry; should be obtained using
+ // GetHumanReadableOrigin().
+ // |username| the username of the saved password entry.
// |password_value| the value of saved password entry at |index|.
virtual void ShowPassword(size_t index,
+ const std::string& origin_url,
+ const std::string& username,
const base::string16& password_value) = 0;
// Updates the list of passwords in the UI.
« chrome/browser/extensions/api/passwords_private/passwords_private_api.h ('K') | « chrome/browser/ui/passwords/password_manager_presenter.cc ('k') | chrome/browser/ui/webui/options/password_manager_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698