Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Unified Diff: sdk/lib/_internal/pub/lib/src/solver/version_selection.dart

Issue 1142693002: Fix a crash in pub's version solver. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/_internal/pub/lib/src/solver/version_selection.dart
diff --git a/sdk/lib/_internal/pub/lib/src/solver/version_selection.dart b/sdk/lib/_internal/pub/lib/src/solver/version_selection.dart
index cabf450951536cdf748d34f124d1054d4761f855..c815f9f75ba62292dab7615a148f10d6cc8c1ae4 100644
--- a/sdk/lib/_internal/pub/lib/src/solver/version_selection.dart
+++ b/sdk/lib/_internal/pub/lib/src/solver/version_selection.dart
@@ -68,12 +68,6 @@ class VersionSelection {
// unselected queue.
if (deps.length == 1 && dep.name != _solver.root.name) {
await _unselected.add(dep.toRef());
-
- // If the package depends on barback, add pub's implicit dependency on
- // barback and related packages as well.
- if (dep.name == 'barback') {
- await _unselected.add(new PackageRef.magic('pub itself'));
- }
}
});
}
@@ -89,12 +83,6 @@ class VersionSelection {
if (deps.isEmpty) {
_unselected.remove(dep.toRef());
-
- // If this was the last package that depended on barback, get rid of
- // pub's implicit dependency.
- if (dep.name == 'barback') {
- _unselected.remove(new PackageRef.magic('pub itself'));
- }
}
}
}
« no previous file with comments | « sdk/lib/_internal/pub/lib/src/solver/backtracking_solver.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698