Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1173)

Issue 1142643002: Revert of Disable blink_perf.canvas on linux. (Closed)

Created:
5 years, 7 months ago by shatch
Modified:
5 years, 7 months ago
Reviewers:
sullivan
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable blink_perf.canvas on linux. (patchset #1 id:1 of https://codereview.chromium.org/1129383007/) Reason for revert: Possible fix has landed, reverting to see if bot goes green. Original issue's description: > Disable blink_perf.canvas on linux. > > This has been red going on a week now. > > BUG=488059 > CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:linux_perf_bisect;tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect > > Committed: https://crrev.com/2e2d7141b8f141bfb194427afde9fb2bf1ed5486 > Cr-Commit-Position: refs/heads/master@{#330085} TBR=sullivan@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=488059 Committed: https://crrev.com/c67128f7fb96c1e40bfb46a9ba7a1466a754f357 Cr-Commit-Position: refs/heads/master@{#330086}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M tools/perf/benchmarks/blink_perf.py View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shatch
Created Revert of Disable blink_perf.canvas on linux.
5 years, 7 months ago (2015-05-15 13:38:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1142643002/1
5 years, 7 months ago (2015-05-15 13:38:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 13:39:28 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c67128f7fb96c1e40bfb46a9ba7a1466a754f357 Cr-Commit-Position: refs/heads/master@{#330086}
5 years, 7 months ago (2015-05-15 13:40:08 UTC) #4
Sami
5 years, 7 months ago (2015-05-15 17:45:30 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1131853007/ by skyostil@chromium.org.

The reason for reverting is: Looks like this is still failing consistently :(

http://build.chromium.org/p/chromium.perf/builders/Linux%20Perf%20(4).

Powered by Google App Engine
This is Rietveld 408576698